Title: [170018] trunk/Source/WebKit2
- Revision
- 170018
- Author
- [email protected]
- Date
- 2014-06-16 12:00:35 -0700 (Mon, 16 Jun 2014)
Log Message
[Cocoa] Remove WKPreferences persistence in user defaults
https://bugs.webkit.org/show_bug.cgi?id=133945
Reviewed by Anders Carlsson.
* UIProcess/API/Cocoa/WKPreferences.h: Removed userDefaultsKeyPrefix property and
initializer with userDefaultsKeyPrefix parameter.
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]): Changed to initialize an instance with an empty identifier, which
means that it won’t persist to user defaults.
(-[WKPreferences initWithUserDefaultsKeyPrefix:]): Deleted.
(-[WKPreferences userDefaultsKeyPrefix]): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170017 => 170018)
--- trunk/Source/WebKit2/ChangeLog 2014-06-16 18:20:02 UTC (rev 170017)
+++ trunk/Source/WebKit2/ChangeLog 2014-06-16 19:00:35 UTC (rev 170018)
@@ -1,3 +1,18 @@
+2014-06-16 Dan Bernstein <[email protected]>
+
+ [Cocoa] Remove WKPreferences persistence in user defaults
+ https://bugs.webkit.org/show_bug.cgi?id=133945
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/API/Cocoa/WKPreferences.h: Removed userDefaultsKeyPrefix property and
+ initializer with userDefaultsKeyPrefix parameter.
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences init]): Changed to initialize an instance with an empty identifier, which
+ means that it won’t persist to user defaults.
+ (-[WKPreferences initWithUserDefaultsKeyPrefix:]): Deleted.
+ (-[WKPreferences userDefaultsKeyPrefix]): Deleted.
+
2014-06-16 Zan Dobersek <[email protected]>
Page::findStringMatchingRanges() should take Vector<RefPtr<Range>> by reference instead of pointer
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h (170017 => 170018)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h 2014-06-16 18:20:02 UTC (rev 170017)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h 2014-06-16 19:00:35 UTC (rev 170018)
@@ -37,20 +37,6 @@
WK_CLASS_AVAILABLE(10_10, 8_0)
@interface WKPreferences : NSObject
-/*! @abstract Returns an initialized preferences object.
- @param userDefaultsKeyPrefix The user defaults key prefix.
- @result An initialized preferences object.
- @discussion If the userDefaultsKeyPrefix parameter is not nil, it is
- prepended to the keys used to store preferences in the user defaults
- database. If the parameter is nil, the preferences object will not save
- anything to the user defaults database.
- */
-- (instancetype)initWithUserDefaultsKeyPrefix:(NSString *)userDefaultsKeyPrefix WK_DESIGNATED_INITIALIZER;
-
-/*! @abstract The user defaults key prefix.
- */
-@property (nonatomic, readonly) NSString *userDefaultsKeyPrefix;
-
/*! @abstract The minimum font size in points.
@discussion The default value is 0.
*/
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm (170017 => 170018)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2014-06-16 18:20:02 UTC (rev 170017)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2014-06-16 19:00:35 UTC (rev 170018)
@@ -32,31 +32,16 @@
#import <wtf/RetainPtr.h>
@implementation WKPreferences
-{
- RetainPtr<NSString> _userDefaultsKeyPrefix;
-}
- (instancetype)init
{
- return [self initWithUserDefaultsKeyPrefix:nil];
-}
-
-- (instancetype)initWithUserDefaultsKeyPrefix:(NSString *)userDefaultsKeyPrefix
-{
if (!(self = [super init]))
return nil;
- _userDefaultsKeyPrefix = adoptNS([userDefaultsKeyPrefix copy]);
-
- _preferences = WebKit::WebPreferences::create(_userDefaultsKeyPrefix.get(), "WebKit");
+ _preferences = WebKit::WebPreferences::create("WebKit", String());
return self;
}
-- (NSString *)userDefaultsKeyPrefix
-{
- return _userDefaultsKeyPrefix.get();
-}
-
- (CGFloat)minimumFontSize
{
return _preferences->minimumFontSize();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
