Title: [170033] trunk/Source/WebCore
- Revision
- 170033
- Author
- [email protected]
- Date
- 2014-06-16 15:57:28 -0700 (Mon, 16 Jun 2014)
Log Message
Remove unnecessary style invalidation in RenderTextControl::styleDidChange().
<https://webkit.org/b/133949>
This explicit invalidation of the text control's inner text element
was hacked in to fix an editing test back in 2011, long before lazy
render tree construction.
It should be safe to remove, since doing so doesn't affect any tests.
Reviewed by Antti Koivisto.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::styleDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (170032 => 170033)
--- trunk/Source/WebCore/ChangeLog 2014-06-16 22:57:16 UTC (rev 170032)
+++ trunk/Source/WebCore/ChangeLog 2014-06-16 22:57:28 UTC (rev 170033)
@@ -1,3 +1,19 @@
+2014-06-16 Andreas Kling <[email protected]>
+
+ Remove unnecessary style invalidation in RenderTextControl::styleDidChange().
+ <https://webkit.org/b/133949>
+
+ This explicit invalidation of the text control's inner text element
+ was hacked in to fix an editing test back in 2011, long before lazy
+ render tree construction.
+
+ It should be safe to remove, since doing so doesn't affect any tests.
+
+ Reviewed by Antti Koivisto.
+
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::styleDidChange):
+
2014-06-16 Anders Carlsson <[email protected]>
Fix iOS build.
Modified: trunk/Source/WebCore/rendering/RenderTextControl.cpp (170032 => 170033)
--- trunk/Source/WebCore/rendering/RenderTextControl.cpp 2014-06-16 22:57:16 UTC (rev 170032)
+++ trunk/Source/WebCore/rendering/RenderTextControl.cpp 2014-06-16 22:57:28 UTC (rev 170033)
@@ -69,7 +69,6 @@
innerTextRenderer->style().setHeight(Length());
innerTextRenderer->style().setWidth(Length());
innerTextRenderer->setStyle(createInnerTextStyle(&style()));
- innerText->setNeedsStyleRecalc();
}
textFormControlElement().updatePlaceholderVisibility(false);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
