Title: [170066] trunk/Source/WebKit2
- Revision
- 170066
- Author
- [email protected]
- Date
- 2014-06-17 12:04:40 -0700 (Tue, 17 Jun 2014)
Log Message
Remove WKContentView _setFindIndicator:fadeOut:animate:
https://bugs.webkit.org/show_bug.cgi?id=133976
Reviewed by Anders Carlsson.
Find indicators are totally internal to FindController on iOS,
we don't need to push them to the content view via PageClient,
so this code was unused.
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/ios/WKContentView.h:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView _setFindIndicator:WebKit::fadeOut:animate:]): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170065 => 170066)
--- trunk/Source/WebKit2/ChangeLog 2014-06-17 19:03:04 UTC (rev 170065)
+++ trunk/Source/WebKit2/ChangeLog 2014-06-17 19:04:40 UTC (rev 170066)
@@ -1,3 +1,20 @@
+2014-06-17 Tim Horton <[email protected]>
+
+ Remove WKContentView _setFindIndicator:fadeOut:animate:
+ https://bugs.webkit.org/show_bug.cgi?id=133976
+
+ Reviewed by Anders Carlsson.
+
+ Find indicators are totally internal to FindController on iOS,
+ we don't need to push them to the content view via PageClient,
+ so this code was unused.
+
+ * UIProcess/ios/PageClientImplIOS.mm:
+ (WebKit::PageClientImpl::setFindIndicator):
+ * UIProcess/ios/WKContentView.h:
+ * UIProcess/ios/WKContentView.mm:
+ (-[WKContentView _setFindIndicator:WebKit::fadeOut:animate:]): Deleted.
+
2014-06-17 Andreas Kling <[email protected]>
Web process main thread priority is lower than some network process threads.
Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm (170065 => 170066)
--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm 2014-06-17 19:03:04 UTC (rev 170065)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm 2014-06-17 19:04:40 UTC (rev 170066)
@@ -372,7 +372,6 @@
void PageClientImpl::setFindIndicator(PassRefPtr<FindIndicator> findIndicator, bool fadeOut, bool animate)
{
- [m_contentView _setFindIndicator:findIndicator fadeOut:fadeOut animate:animate];
}
void PageClientImpl::enterAcceleratedCompositingMode(const LayerTreeContext& layerTreeContext)
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentView.h (170065 => 170066)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentView.h 2014-06-17 19:03:04 UTC (rev 170065)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentView.h 2014-06-17 19:04:40 UTC (rev 170066)
@@ -86,6 +86,4 @@
- (BOOL)_zoomToRect:(CGRect)targetRect withOrigin:(CGPoint)origin fitEntireRect:(BOOL)fitEntireRect minimumScale:(double)minimumScale maximumScale:(double)maximumScale minimumScrollDistance:(CGFloat)minimumScrollDistance;
- (void)_zoomOutWithOrigin:(CGPoint)origin;
-- (void)_setFindIndicator:(PassRefPtr<WebKit::FindIndicator>)findIndicator fadeOut:(BOOL)fadeOut animate:(BOOL)animate;
-
@end
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm (170065 => 170066)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm 2014-06-17 19:03:04 UTC (rev 170065)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm 2014-06-17 19:04:40 UTC (rev 170066)
@@ -465,11 +465,6 @@
_page->applicationDidBecomeActive();
}
-- (void)_setFindIndicator:(PassRefPtr<WebKit::FindIndicator>)findIndicator fadeOut:(BOOL)fadeOut animate:(BOOL)animate
-{
- notImplemented();
-}
-
@end
#endif // PLATFORM(IOS)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
