Title: [170077] trunk/Source/WebInspectorUI
- Revision
- 170077
- Author
- [email protected]
- Date
- 2014-06-17 15:26:15 -0700 (Tue, 17 Jun 2014)
Log Message
Web Inspector: style declaration editor: visual highlight doesn't match actual selected text
https://bugs.webkit.org/show_bug.cgi?id=133965
Reviewed by Joseph Pecoraro.
Update styles for css style editor to fix highlighting visual mismatch glitch.
* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor > .CodeMirror .CodeMirror-placeholder):
(.css-style-text-editor > .CodeMirror pre):
(.css-style-text-editor.read-only > .CodeMirror pre):
Updated styles to eliminate highlight mismatch by adjusting the padding and
text-indent values.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (170076 => 170077)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-06-17 22:17:26 UTC (rev 170076)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-06-17 22:26:15 UTC (rev 170077)
@@ -1,3 +1,19 @@
+2014-06-17 Jono Wells <[email protected]>
+
+ Web Inspector: style declaration editor: visual highlight doesn't match actual selected text
+ https://bugs.webkit.org/show_bug.cgi?id=133965
+
+ Reviewed by Joseph Pecoraro.
+
+ Update styles for css style editor to fix highlighting visual mismatch glitch.
+
+ * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
+ (.css-style-text-editor > .CodeMirror .CodeMirror-placeholder):
+ (.css-style-text-editor > .CodeMirror pre):
+ (.css-style-text-editor.read-only > .CodeMirror pre):
+ Updated styles to eliminate highlight mismatch by adjusting the padding and
+ text-indent values.
+
2014-06-10 Brian J. Burg <[email protected]>
Web Inspector: recording is overused as both noun and verb in TimelineManager
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css (170076 => 170077)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css 2014-06-17 22:17:26 UTC (rev 170076)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css 2014-06-17 22:26:15 UTC (rev 170077)
@@ -39,13 +39,13 @@
.css-style-text-editor > .CodeMirror .CodeMirror-placeholder {
font-family: "Lucida Grande", sans-serif;
color: rgb(128, 128, 128);
- padding: 0 5px 0 39px;
- text-indent: -14px;
+ padding: 0 5px 0 25px;
}
.css-style-text-editor > .CodeMirror pre {
- padding: 1px 5px 1px 39px;
- text-indent: -35px;
+ /* Compensate for the checkboxes so properties line up with readonly styles that do not have checkboxes. */
+ padding: 1px 5px 1px 25px;
+ text-indent: -21px;
}
.css-style-text-editor > .CodeMirror pre * {
@@ -53,8 +53,7 @@
}
.css-style-text-editor.read-only > .CodeMirror pre {
- /* Compensate for the missing checkboxes so properties line up with editable styles that have checkboxes. */
- text-indent: -14px;
+ text-indent: 0;
}
.css-style-text-editor.read-only > .CodeMirror .CodeMirror-cursor {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
