Title: [170217] trunk/Source/WebKit2
- Revision
- 170217
- Author
- [email protected]
- Date
- 2014-06-20 15:40:30 -0700 (Fri, 20 Jun 2014)
Log Message
Snapshotting WKThumbnailViews should not tell Web processes backing unparented WKViews that they're in window
https://bugs.webkit.org/show_bug.cgi?id=134134
<rdar://problem/17402119>
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKView.mm:
(-[WKView _setThumbnailView:]):
Re-evaluating our in-window state is only useful if we're going to use the live layer tree;
snapshots can be taken of unparented views with no trouble. Plus, doing so sets off a chain of
expensive things in the Web process which we can avoid if using snapshots.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170216 => 170217)
--- trunk/Source/WebKit2/ChangeLog 2014-06-20 22:38:21 UTC (rev 170216)
+++ trunk/Source/WebKit2/ChangeLog 2014-06-20 22:40:30 UTC (rev 170217)
@@ -1,5 +1,19 @@
2014-06-20 Timothy Horton <[email protected]>
+ Snapshotting WKThumbnailViews should not tell Web processes backing unparented WKViews that they're in window
+ https://bugs.webkit.org/show_bug.cgi?id=134134
+ <rdar://problem/17402119>
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView _setThumbnailView:]):
+ Re-evaluating our in-window state is only useful if we're going to use the live layer tree;
+ snapshots can be taken of unparented views with no trouble. Plus, doing so sets off a chain of
+ expensive things in the Web process which we can avoid if using snapshots.
+
+2014-06-20 Timothy Horton <[email protected]>
+
WKThumbnailView should only use live layer trees before the snapshot arrives for parented WKViews
https://bugs.webkit.org/show_bug.cgi?id=134129
<rdar://problem/17401591>
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (170216 => 170217)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-06-20 22:38:21 UTC (rev 170216)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-06-20 22:40:30 UTC (rev 170217)
@@ -3515,7 +3515,8 @@
else
[self _setAcceleratedCompositingModeRootLayer:_data->_rootLayer.get()];
- _data->_page->viewStateDidChange(ViewState::WindowIsActive | ViewState::IsInWindow | ViewState::IsVisible);
+ if (!thumbnailView.usesSnapshot)
+ _data->_page->viewStateDidChange(ViewState::WindowIsActive | ViewState::IsInWindow | ViewState::IsVisible);
}
- (_WKThumbnailView *)_thumbnailView
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
