Title: [170443] trunk/Source/WebCore
- Revision
- 170443
- Author
- jer.no...@apple.com
- Date
- 2014-06-25 15:45:20 -0700 (Wed, 25 Jun 2014)
Log Message
[MSE][Mac] REGRESSION(r170336) - zero tolerance seeks are ignored.
https://bugs.webkit.org/show_bug.cgi?id=134310
Reviewed by Brent Fulgham.
Tests for zero tolerance seeks were inadvertantly reversed in r170336.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (170442 => 170443)
--- trunk/Source/WebCore/ChangeLog 2014-06-25 22:37:37 UTC (rev 170442)
+++ trunk/Source/WebCore/ChangeLog 2014-06-25 22:45:20 UTC (rev 170443)
@@ -1,5 +1,17 @@
2014-06-25 Jer Noble <jer.no...@apple.com>
+ [MSE][Mac] REGRESSION(r170336) - zero tolerance seeks are ignored.
+ https://bugs.webkit.org/show_bug.cgi?id=134310
+
+ Reviewed by Brent Fulgham.
+
+ Tests for zero tolerance seeks were inadvertantly reversed in r170336.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
+
+2014-06-25 Jer Noble <jer.no...@apple.com>
+
[MSE][Mac] Pause playback when readyState drops below HAVE_FUTURE_DATA, and do not complete seek until it rises above HAVE_METADATA.
https://bugs.webkit.org/show_bug.cgi?id=134306
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (170442 => 170443)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2014-06-25 22:37:37 UTC (rev 170442)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2014-06-25 22:45:20 UTC (rev 170443)
@@ -455,7 +455,7 @@
return;
MediaTime seekTime;
- if (pendingSeek->negativeThreshold != MediaTime::zeroTime() && pendingSeek->positiveThreshold != MediaTime::zeroTime())
+ if (pendingSeek->negativeThreshold == MediaTime::zeroTime() && pendingSeek->positiveThreshold == MediaTime::zeroTime())
seekTime = pendingSeek->targetTime;
else
seekTime = m_mediaSourcePrivate->fastSeekTimeForMediaTime(pendingSeek->targetTime, pendingSeek->positiveThreshold, pendingSeek->negativeThreshold);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
