Title: [170496] trunk/Source/WebKit/mac
Revision
170496
Author
[email protected]
Date
2014-06-26 15:12:41 -0700 (Thu, 26 Jun 2014)

Log Message

[iOS] Remove User Default for iOS TextField Debugging
https://bugs.webkit.org/show_bug.cgi?id=134356

Patch by Joseph Pecoraro <[email protected]> on 2014-06-26
Reviewed by Timothy Hatcher.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (170495 => 170496)


--- trunk/Source/WebKit/mac/ChangeLog	2014-06-26 21:23:02 UTC (rev 170495)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-06-26 22:12:41 UTC (rev 170496)
@@ -1,3 +1,14 @@
+2014-06-26  Joseph Pecoraro  <[email protected]>
+
+        [iOS] Remove User Default for iOS TextField Debugging
+        https://bugs.webkit.org/show_bug.cgi?id=134356
+
+        Reviewed by Timothy Hatcher.
+
+        * WebView/WebPreferenceKeysPrivate.h:
+        * WebView/WebView.mm:
+        (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
+
 2014-06-25  Brady Eidson  <[email protected]>
 
         Add HID-based gamepad implementation for Mac

Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (170495 => 170496)


--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h	2014-06-26 21:23:02 UTC (rev 170495)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h	2014-06-26 22:12:41 UTC (rev 170496)
@@ -202,10 +202,4 @@
 #define WebKitDiskImageCacheMaximumCacheSizePreferenceKey @"WebKitDiskImageCacheMaximumCacheSize"
 #define WebKitDiskImageCacheSavedCacheDirectoryKey @"WebKitDiskImageCacheSavedCacheDirectory"
 
-#if TARGET_OS_IPHONE
-#if !defined(ENABLE_REMOTE_INSPECTOR) || ENABLE_REMOTE_INSPECTOR
-#define WebKitTextFieldRemoteInspectionEnabledPreferenceKey @"WebKitTextFieldRemoteInspectionEnabled"
-#endif
-#endif
-
 #define WebKitEnableInheritURIQueryComponentPreferenceKey @"WebKitEnableInheritURIQueryComponent"

Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (170495 => 170496)


--- trunk/Source/WebKit/mac/WebView/WebView.mm	2014-06-26 21:23:02 UTC (rev 170495)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm	2014-06-26 22:12:41 UTC (rev 170496)
@@ -1189,14 +1189,7 @@
     [self setGroupName:groupName];
 
 #if ENABLE(REMOTE_INSPECTOR)
-    // Production installs always disallow debugging simple HTML documents.
-    // Internal installs allow debugging simple HTML documents (TextFields) if the Internal Setting is enabled.
-    if (!isInternalInstall())
-        _private->page->setRemoteInspectionAllowed(false);
-    else {
-        static BOOL textFieldInspectionEnabled = [[NSUserDefaults standardUserDefaults] boolForKey:WebKitTextFieldRemoteInspectionEnabledPreferenceKey];
-        _private->page->setRemoteInspectionAllowed(textFieldInspectionEnabled);
-    }
+    _private->page->setRemoteInspectionAllowed(isInternalInstall());
 #endif
     
     [self _updateScreenScaleFromWindow];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to