Title: [170508] trunk/Source/WebKit2
Revision
170508
Author
[email protected]
Date
2014-06-26 16:53:37 -0700 (Thu, 26 Jun 2014)

Log Message

Don't leak WKBrowsingContextControllers
https://bugs.webkit.org/show_bug.cgi?id=134368
<rdar://problem/17476582>

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKView.mm:
(-[WKView browsingContextController]):
Adoption is important.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (170507 => 170508)


--- trunk/Source/WebKit2/ChangeLog	2014-06-26 23:48:33 UTC (rev 170507)
+++ trunk/Source/WebKit2/ChangeLog	2014-06-26 23:53:37 UTC (rev 170508)
@@ -1,3 +1,15 @@
+2014-06-26  Tim Horton  <[email protected]>
+
+        Don't leak WKBrowsingContextControllers
+        https://bugs.webkit.org/show_bug.cgi?id=134368
+        <rdar://problem/17476582>
+
+        Reviewed by Sam Weinig.
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView browsingContextController]):
+        Adoption is important.
+
 2014-06-26  Alexey Proskuryakov  <[email protected]>
 
         REGRESSION: Mountain Lion: Gmail's "in new window" view of mail threads is very slow to load its content

Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (170507 => 170508)


--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2014-06-26 23:48:33 UTC (rev 170507)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2014-06-26 23:53:37 UTC (rev 170508)
@@ -315,7 +315,7 @@
 - (WKBrowsingContextController *)browsingContextController
 {
     if (!_data->_browsingContextController)
-        _data->_browsingContextController = [[WKBrowsingContextController alloc] _initWithPageRef:toAPI(_data->_page.get())];
+        _data->_browsingContextController = adoptNS([[WKBrowsingContextController alloc] _initWithPageRef:toAPI(_data->_page.get())]);
 
     return _data->_browsingContextController.get();
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to