Title: [170604] branches/ftlopt/Source/_javascript_Core
- Revision
- 170604
- Author
- [email protected]
- Date
- 2014-06-30 15:22:31 -0700 (Mon, 30 Jun 2014)
Log Message
CodeBlock::stronglyVisitWeakReferences should mark DFG::CommonData::weakStructureReferences
https://bugs.webkit.org/show_bug.cgi?id=134455
Reviewed by Geoffrey Garen.
Otherwise we get hanging pointers which can cause us to die later.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitWeakReferences):
Modified Paths
Diff
Modified: branches/ftlopt/Source/_javascript_Core/ChangeLog (170603 => 170604)
--- branches/ftlopt/Source/_javascript_Core/ChangeLog 2014-06-30 22:14:35 UTC (rev 170603)
+++ branches/ftlopt/Source/_javascript_Core/ChangeLog 2014-06-30 22:22:31 UTC (rev 170604)
@@ -1,3 +1,15 @@
+2014-06-30 Mark Hahnenberg <[email protected]>
+
+ CodeBlock::stronglyVisitWeakReferences should mark DFG::CommonData::weakStructureReferences
+ https://bugs.webkit.org/show_bug.cgi?id=134455
+
+ Reviewed by Geoffrey Garen.
+
+ Otherwise we get hanging pointers which can cause us to die later.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::stronglyVisitWeakReferences):
+
2014-06-27 Filip Pizlo <[email protected]>
[ftlopt] Reduce the GC's influence on optimization decisions
Modified: branches/ftlopt/Source/_javascript_Core/bytecode/CodeBlock.cpp (170603 => 170604)
--- branches/ftlopt/Source/_javascript_Core/bytecode/CodeBlock.cpp 2014-06-30 22:14:35 UTC (rev 170603)
+++ branches/ftlopt/Source/_javascript_Core/bytecode/CodeBlock.cpp 2014-06-30 22:22:31 UTC (rev 170604)
@@ -2691,6 +2691,9 @@
for (unsigned i = 0; i < dfgCommon->weakReferences.size(); ++i)
visitor.append(&dfgCommon->weakReferences[i]);
+
+ for (unsigned i = 0; i < dfgCommon->weakStructureReferences.size(); ++i)
+ visitor.append(&dfgCommon->weakStructureReferences[i]);
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
