Title: [170607] trunk/Source/WebKit2
Revision
170607
Author
[email protected]
Date
2014-06-30 15:50:59 -0700 (Mon, 30 Jun 2014)

Log Message

[iOS WK2] Turn off scrollsToTop on overflow UIScrollViews
https://bugs.webkit.org/show_bug.cgi?id=134456

Reviewed by Tim Horton.

Set scrollsToTop to NO on our UIScrollViews created for overflow scrolling, since
we don't have a good strategy for when to allow it, and doing so would also require
some smarts in the main UIScrollView.

* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (170606 => 170607)


--- trunk/Source/WebKit2/ChangeLog	2014-06-30 22:50:28 UTC (rev 170606)
+++ trunk/Source/WebKit2/ChangeLog	2014-06-30 22:50:59 UTC (rev 170607)
@@ -1,3 +1,17 @@
+2014-06-30  Simon Fraser  <[email protected]>
+
+        [iOS WK2] Turn off scrollsToTop on overflow UIScrollViews
+        https://bugs.webkit.org/show_bug.cgi?id=134456
+
+        Reviewed by Tim Horton.
+        
+        Set scrollsToTop to NO on our UIScrollViews created for overflow scrolling, since
+        we don't have a good strategy for when to allow it, and doing so would also require
+        some smarts in the main UIScrollView.
+
+        * UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
+        (WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
+
 2014-06-30  Enrica Casucci  <[email protected]>
 
         REGRESSION (Okemo): The contextual menu on tap and hold does not cancel the other gestures.

Modified: trunk/Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm (170606 => 170607)


--- trunk/Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm	2014-06-30 22:50:28 UTC (rev 170606)
+++ trunk/Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm	2014-06-30 22:50:59 UTC (rev 170607)
@@ -155,6 +155,7 @@
             if (!m_scrollViewDelegate)
                 m_scrollViewDelegate = adoptNS([[WKOverflowScrollViewDelegate alloc] initWithScrollingTreeNode:this]);
 
+            scrollView.scrollsToTop = NO;
             scrollView.delegate = m_scrollViewDelegate.get();
         }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to