Title: [170665] trunk/Source/WebCore
- Revision
- 170665
- Author
- commit-qu...@webkit.org
- Date
- 2014-07-01 14:12:08 -0700 (Tue, 01 Jul 2014)
Log Message
Web Inspector: Selected DOM element highlights invisible near bottom of the viewport (topContentInset?)
https://bugs.webkit.org/show_bug.cgi?id=133818
Patch by Joseph Pecoraro <pecor...@apple.com> on 2014-07-01
Reviewed by Beth Dakin.
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
Take the topContentInset into account when sizing the InspectorOverlay's FrameView.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (170664 => 170665)
--- trunk/Source/WebCore/ChangeLog 2014-07-01 21:07:40 UTC (rev 170664)
+++ trunk/Source/WebCore/ChangeLog 2014-07-01 21:12:08 UTC (rev 170665)
@@ -1,3 +1,14 @@
+2014-07-01 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Selected DOM element highlights invisible near bottom of the viewport (topContentInset?)
+ https://bugs.webkit.org/show_bug.cgi?id=133818
+
+ Reviewed by Beth Dakin.
+
+ * inspector/InspectorOverlay.cpp:
+ (WebCore::InspectorOverlay::update):
+ Take the topContentInset into account when sizing the InspectorOverlay's FrameView.
+
2014-07-01 Chris Fleizach <cfleiz...@apple.com>
AX: HTML indeterminate IDL attribute not mapped to checkbox value=2
Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (170664 => 170665)
--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2014-07-01 21:07:40 UTC (rev 170664)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2014-07-01 21:12:08 UTC (rev 170665)
@@ -63,9 +63,7 @@
namespace WebCore {
-namespace {
-
-Path quadToPath(const FloatQuad& quad)
+static Path quadToPath(const FloatQuad& quad)
{
Path quadPath;
quadPath.moveTo(quad.p1());
@@ -76,7 +74,7 @@
return quadPath;
}
-void drawOutlinedQuad(GraphicsContext* context, const FloatQuad& quad, const Color& fillColor, const Color& outlineColor)
+static void drawOutlinedQuad(GraphicsContext* context, const FloatQuad& quad, const Color& fillColor, const Color& outlineColor)
{
static const int outlineThickness = 2;
@@ -237,8 +235,6 @@
highlight->quads.append(quad);
}
-} // anonymous namespace
-
InspectorOverlay::InspectorOverlay(Page& page, InspectorClient* client)
: m_page(page)
, m_client(client)
@@ -348,8 +344,8 @@
return;
FrameView* overlayView = overlayPage()->mainFrame().view();
- IntSize viewportSize = view->visibleContentRect().size();
- IntSize frameViewFullSize = view->visibleContentRectIncludingScrollbars().size();
+ IntSize viewportSize = view->unscaledTotalVisibleContentSize();
+ IntSize frameViewFullSize = view->unscaledTotalVisibleContentSize(ScrollableArea::IncludeScrollbars);
overlayPage()->setPageScaleFactor(m_page.pageScaleFactor(), IntPoint());
frameViewFullSize.scale(m_page.pageScaleFactor());
overlayView->resize(frameViewFullSize);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
