Title: [170668] trunk/Source/WebKit2
- Revision
- 170668
- Author
- [email protected]
- Date
- 2014-07-01 14:21:09 -0700 (Tue, 01 Jul 2014)
Log Message
Fix ServicesOverlayController teardown
<rdar://problem/17523998> and https://bugs.webkit.org/show_bug.cgi?id=134510
Reviewed by Mark Rowe.
* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::~ServicesOverlayController): Flipped logic on null-checking the overlay.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170667 => 170668)
--- trunk/Source/WebKit2/ChangeLog 2014-07-01 21:16:14 UTC (rev 170667)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-01 21:21:09 UTC (rev 170668)
@@ -1,3 +1,13 @@
+2014-07-01 Brady Eidson <[email protected]>
+
+ Fix ServicesOverlayController teardown
+ <rdar://problem/17523998> and https://bugs.webkit.org/show_bug.cgi?id=134510
+
+ Reviewed by Mark Rowe.
+
+ * WebProcess/WebPage/mac/ServicesOverlayController.mm:
+ (WebKit::ServicesOverlayController::~ServicesOverlayController): Flipped logic on null-checking the overlay.
+
2014-07-01 Sam Weinig <[email protected]>
[Cocoa][Mac] WKWebView should automatically set topContentInset when beneath a toolbar
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm (170667 => 170668)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm 2014-07-01 21:16:14 UTC (rev 170667)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm 2014-07-01 21:21:09 UTC (rev 170668)
@@ -83,7 +83,7 @@
ServicesOverlayController::~ServicesOverlayController()
{
- if (!m_servicesOverlay) {
+ if (m_servicesOverlay) {
ASSERT(m_webPage);
m_webPage->uninstallPageOverlay(m_servicesOverlay, PageOverlay::FadeMode::DoNotFade);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
