Title: [170760] trunk/Source/WebKit2
- Revision
- 170760
- Author
- beid...@apple.com
- Date
- 2014-07-03 12:16:27 -0700 (Thu, 03 Jul 2014)
Log Message
Followup to "rects sent to ServicesOverlayController are wrong"
https://bugs.webkit.org/show_bug.cgi?id=134568
Rubberstamped by Tim Horton.
* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::drawSelectionHighlight): Don’t check to see if the
proposed rect intersects the dirty rect. We always need to include all rects that form
the selection when creating the DDHighlight.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170759 => 170760)
--- trunk/Source/WebKit2/ChangeLog 2014-07-03 19:04:34 UTC (rev 170759)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-03 19:16:27 UTC (rev 170760)
@@ -1,3 +1,15 @@
+2014-07-03 Brady Eidson <beid...@apple.com>
+
+ Followup to "rects sent to ServicesOverlayController are wrong"
+ https://bugs.webkit.org/show_bug.cgi?id=134568
+
+ Rubberstamped by Tim Horton.
+
+ * WebProcess/WebPage/mac/ServicesOverlayController.mm:
+ (WebKit::ServicesOverlayController::drawSelectionHighlight): Don’t check to see if the
+ proposed rect intersects the dirty rect. We always need to include all rects that form
+ the selection when creating the DDHighlight.
+
2014-07-03 Tim Horton <timothy_hor...@apple.com>
[WK2] RemoteLayerTreeDrawingAreaProxy re-checks a preference every commit for no reason
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm (170759 => 170760)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm 2014-07-03 19:04:34 UTC (rev 170759)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm 2014-07-03 19:16:27 UTC (rev 170760)
@@ -288,14 +288,8 @@
Vector<CGRect> cgRects;
cgRects.reserveCapacity(m_currentSelectionRects.size());
- for (auto& rect : m_currentSelectionRects) {
- IntRect selectionRect(rect.pixelSnappedLocation(), rect.pixelSnappedSize());
-
- if (!selectionRect.intersects(dirtyRect))
- continue;
-
+ for (auto& rect : m_currentSelectionRects)
cgRects.append((CGRect)pixelSnappedIntRect(rect));
- }
if (!cgRects.isEmpty()) {
CGRect bounds = m_webPage->corePage()->mainFrame().view()->boundsRect();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
