Title: [170959] tags/Safari-538.45.1/Source/WebKit2
Revision
170959
Author
[email protected]
Date
2014-07-09 23:35:08 -0700 (Wed, 09 Jul 2014)

Log Message

Merged r170948. <rdar://problem/17616971>

Modified Paths

Diff

Modified: tags/Safari-538.45.1/Source/WebKit2/ChangeLog (170958 => 170959)


--- tags/Safari-538.45.1/Source/WebKit2/ChangeLog	2014-07-10 06:14:35 UTC (rev 170958)
+++ tags/Safari-538.45.1/Source/WebKit2/ChangeLog	2014-07-10 06:35:08 UTC (rev 170959)
@@ -1,3 +1,24 @@
+2014-07-09  Babak Shafiei  <[email protected]>
+
+        Merge r170948.
+
+    2014-07-09  Enrica Casucci  <[email protected]>
+
+            REGRESSION(r170858): Safari freezes upon making a search on a website (yelp.com).
+            https://bugs.webkit.org/show_bug.cgi?id=134791
+            <rdar://problem/17616971>
+
+            Reviewed by Benjamin Poulain.
+
+            After r170858 we notify the keyboard too often about
+            the changed selection. This patch removes the notification
+            until we find a better way to do it that doesn't cause
+            deadlocks.
+
+            * UIProcess/ios/WKContentViewInteraction.mm:
+            (-[WKContentView _selectionWillChange]):
+            (-[WKContentView _selectionChanged]):
+
 2014-07-08  Tim Horton  <[email protected]>
 
         Remove WebBackForwardListItems when their owning page goes away

Modified: tags/Safari-538.45.1/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (170958 => 170959)


--- tags/Safari-538.45.1/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2014-07-10 06:14:35 UTC (rev 170958)
+++ tags/Safari-538.45.1/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2014-07-10 06:35:08 UTC (rev 170959)
@@ -2491,9 +2491,6 @@
 
 - (void)_selectionWillChange
 {
-    if (_usingGestureForSelection)
-        return;
-    [self beginSelectionChange];
 }
 
 - (void)_selectionChanged
@@ -2503,8 +2500,6 @@
     // to wait to paint the selection.
     if (_usingGestureForSelection)
         [self _updateChangedSelection];
-    else
-        [self endSelectionChange];
 }
 
 - (void)selectWordForReplacement
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to