Title: [171018] trunk/Source/WebCore
- Revision
- 171018
- Author
- [email protected]
- Date
- 2014-07-11 18:49:11 -0700 (Fri, 11 Jul 2014)
Log Message
Web Inspector: Crash when using a stale InspectableNode Node
https://bugs.webkit.org/show_bug.cgi?id=134849
Patch by Joseph Pecoraro <[email protected]> on 2014-07-11
Reviewed by Timothy Hatcher.
* inspector/PageConsoleAgent.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (171017 => 171018)
--- trunk/Source/WebCore/ChangeLog 2014-07-12 00:53:44 UTC (rev 171017)
+++ trunk/Source/WebCore/ChangeLog 2014-07-12 01:49:11 UTC (rev 171018)
@@ -1,3 +1,12 @@
+2014-07-11 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Crash when using a stale InspectableNode Node
+ https://bugs.webkit.org/show_bug.cgi?id=134849
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/PageConsoleAgent.cpp:
+
2014-07-11 Jer Noble <[email protected]>
[MSE] Separate MediaSource logging into its own log channel
Modified: trunk/Source/WebCore/inspector/PageConsoleAgent.cpp (171017 => 171018)
--- trunk/Source/WebCore/inspector/PageConsoleAgent.cpp 2014-07-12 00:53:44 UTC (rev 171017)
+++ trunk/Source/WebCore/inspector/PageConsoleAgent.cpp 2014-07-12 01:49:11 UTC (rev 171018)
@@ -60,10 +60,10 @@
explicit InspectableNode(Node* node) : m_node(node) { }
virtual Deprecated::ScriptValue get(JSC::ExecState* state) override
{
- return InspectorDOMAgent::nodeAsScriptValue(state, m_node);
+ return InspectorDOMAgent::nodeAsScriptValue(state, m_node.get());
}
private:
- Node* m_node;
+ RefPtr<Node> m_node;
};
void PageConsoleAgent::addInspectedNode(ErrorString* errorString, int nodeId)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
