Title: [171076] trunk/Source/_javascript_Core
Revision
171076
Author
[email protected]
Date
2014-07-14 13:55:14 -0700 (Mon, 14 Jul 2014)

Log Message

Remove some dead code from FTLJITFinalizer
https://bugs.webkit.org/show_bug.cgi?id=134874

Reviewed by Geoffrey Garen.

Not sure what that code was for...but it does not do anything :)

* ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
The pointer of the label is computed but never used.

* ftl/FTLJITFinalizer.h:
* ftl/FTLLink.cpp:
(JSC::FTL::link):
The label is never set to anything.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (171075 => 171076)


--- trunk/Source/_javascript_Core/ChangeLog	2014-07-14 20:12:31 UTC (rev 171075)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-07-14 20:55:14 UTC (rev 171076)
@@ -1,3 +1,21 @@
+2014-07-14  Benjamin Poulain  <[email protected]>
+
+        Remove some dead code from FTLJITFinalizer
+        https://bugs.webkit.org/show_bug.cgi?id=134874
+
+        Reviewed by Geoffrey Garen.
+
+        Not sure what that code was for...but it does not do anything :)
+
+        * ftl/FTLJITFinalizer.cpp:
+        (JSC::FTL::JITFinalizer::finalizeFunction):
+        The pointer of the label is computed but never used.
+
+        * ftl/FTLJITFinalizer.h:
+        * ftl/FTLLink.cpp:
+        (JSC::FTL::link):
+        The label is never set to anything.
+
 2014-07-14  Bear Travis  <[email protected]>
 
         [Feature Queries] Enable Feature Queries on Mac

Modified: trunk/Source/_javascript_Core/ftl/FTLJITFinalizer.cpp (171075 => 171076)


--- trunk/Source/_javascript_Core/ftl/FTLJITFinalizer.cpp	2014-07-14 20:12:31 UTC (rev 171075)
+++ trunk/Source/_javascript_Core/ftl/FTLJITFinalizer.cpp	2014-07-14 20:55:14 UTC (rev 171076)
@@ -128,9 +128,6 @@
             .executableMemory());
     }
     
-    MacroAssemblerCodePtr withArityCheck;
-    if (arityCheck.isSet())
-        withArityCheck = entrypointLinkBuffer->locationOf(arityCheck);
     jitCode->initializeArityCheckEntrypoint(
         FINALIZE_DFG_CODE(
             *entrypointLinkBuffer,

Modified: trunk/Source/_javascript_Core/ftl/FTLJITFinalizer.h (171075 => 171076)


--- trunk/Source/_javascript_Core/ftl/FTLJITFinalizer.h	2014-07-14 20:12:31 UTC (rev 171075)
+++ trunk/Source/_javascript_Core/ftl/FTLJITFinalizer.h	2014-07-14 20:55:14 UTC (rev 171076)
@@ -54,7 +54,6 @@
     OwnPtr<LinkBuffer> handleExceptionsLinkBuffer;
     Vector<SlowPathCall> slowPathCalls; // Calls inside the side code.
     Vector<OSRExitCompilationInfo> osrExit;
-    MacroAssembler::Label arityCheck;
     GeneratedFunction function;
     RefPtr<JITCode> jitCode;
 };

Modified: trunk/Source/_javascript_Core/ftl/FTLLink.cpp (171075 => 171076)


--- trunk/Source/_javascript_Core/ftl/FTLLink.cpp	2014-07-14 20:12:31 UTC (rev 171075)
+++ trunk/Source/_javascript_Core/ftl/FTLLink.cpp	2014-07-14 20:55:14 UTC (rev 171076)
@@ -68,7 +68,6 @@
     CCallHelpers jit(&vm, codeBlock);
     
     OwnPtr<LinkBuffer> linkBuffer;
-    CCallHelpers::Label arityCheck;
 
     CCallHelpers::Address frame = CCallHelpers::Address(
         CCallHelpers::stackPointerRegister, -static_cast<int32_t>(AssemblyHelpers::prologueStackPointerDelta()));
@@ -208,7 +207,6 @@
     
     state.finalizer->entrypointLinkBuffer = linkBuffer.release();
     state.finalizer->function = state.generatedFunction;
-    state.finalizer->arityCheck = arityCheck;
     state.finalizer->jitCode = state.jitCode;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to