Title: [171128] tags/Safari-538.46.3/Source/WebCore
Revision
171128
Author
[email protected]
Date
2014-07-15 17:53:24 -0700 (Tue, 15 Jul 2014)

Log Message

Merged r171099. <rdar://problem/16917699>

Modified Paths

Diff

Modified: tags/Safari-538.46.3/Source/WebCore/ChangeLog (171127 => 171128)


--- tags/Safari-538.46.3/Source/WebCore/ChangeLog	2014-07-16 00:51:13 UTC (rev 171127)
+++ tags/Safari-538.46.3/Source/WebCore/ChangeLog	2014-07-16 00:53:24 UTC (rev 171128)
@@ -1,5 +1,21 @@
 2014-07-15  Babak Shafiei  <[email protected]>
 
+        Merge r171099
+
+    2014-07-14  Jeremy Jones  <[email protected]>
+    
+            Fix crash on WebVideoFullscreenManagerProxy construction.
+            https://bugs.webkit.org/show_bug.cgi?id=134909
+
+            Unreviewed fix crash from r171089
+
+            Remove unnecessary dispatch to main queue since it can happen during construction.
+
+            * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+            (WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel): remove dispatch_async
+
+2014-07-15  Babak Shafiei  <[email protected]>
+
         Merge r171089
 
     2014-07-14  Jeremy Jones  <[email protected]>

Modified: tags/Safari-538.46.3/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (171127 => 171128)


--- tags/Safari-538.46.3/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2014-07-16 00:51:13 UTC (rev 171127)
+++ tags/Safari-538.46.3/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2014-07-16 00:53:24 UTC (rev 171128)
@@ -585,14 +585,7 @@
 void WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel(WebVideoFullscreenModel* model)
 {
     m_videoFullscreenModel = model;
-    __block RefPtr<WebVideoFullscreenInterfaceAVKit> protect(this);
-    
-    dispatch_async(dispatch_get_main_queue(), ^{
-        if (m_playerController)
-            playerController().delegate = m_videoFullscreenModel;
-        
-        protect.clear();
-    });
+    [m_playerController setDelegate:m_videoFullscreenModel];
 }
 
 void WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenChangeObserver(WebVideoFullscreenChangeObserver* observer)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to