Title: [171145] trunk/Source/WebCore
- Revision
- 171145
- Author
- [email protected]
- Date
- 2014-07-16 08:38:55 -0700 (Wed, 16 Jul 2014)
Log Message
Substitute CGRectZero for NSZeroRect in -[DOMNode hrefFrame].
Rubber-stamped by Zalan Bujtas.
The method -[DOMNode hrefFrame] returns a CGRect. So, when we don't have a renderer
we should return CGRectZero instead of a NSZeroRect.
* bindings/objc/DOM.mm:
(-[DOMNode hrefFrame]): Also, fix up some code style issues.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (171144 => 171145)
--- trunk/Source/WebCore/ChangeLog 2014-07-16 15:03:37 UTC (rev 171144)
+++ trunk/Source/WebCore/ChangeLog 2014-07-16 15:38:55 UTC (rev 171145)
@@ -1,3 +1,15 @@
+2014-07-16 Daniel Bates <[email protected]>
+
+ Substitute CGRectZero for NSZeroRect in -[DOMNode hrefFrame].
+
+ Rubber-stamped by Zalan Bujtas.
+
+ The method -[DOMNode hrefFrame] returns a CGRect. So, when we don't have a renderer
+ we should return CGRectZero instead of a NSZeroRect.
+
+ * bindings/objc/DOM.mm:
+ (-[DOMNode hrefFrame]): Also, fix up some code style issues.
+
2014-07-16 Jeongeun Kim <[email protected]>
mutable pointers from const methods, timeContainer().
Modified: trunk/Source/WebCore/bindings/objc/DOM.mm (171144 => 171145)
--- trunk/Source/WebCore/bindings/objc/DOM.mm 2014-07-16 15:03:37 UTC (rev 171144)
+++ trunk/Source/WebCore/bindings/objc/DOM.mm 2014-07-16 15:38:55 UTC (rev 171145)
@@ -465,10 +465,9 @@
- (CGRect)hrefFrame
{
RenderObject *renderer = [self _linkElement]->renderer();
-
- if(renderer) return renderer->absoluteBoundingBoxRect();
-
- return NSZeroRect;
+ if (renderer)
+ return renderer->absoluteBoundingBoxRect();
+ return CGRectZero;
}
- (NSString *)hrefLabel
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes