Title: [171189] branches/ftlopt/LayoutTests
- Revision
- 171189
- Author
- [email protected]
- Date
- 2014-07-17 10:43:31 -0700 (Thu, 17 Jul 2014)
Log Message
sputnik/Implementation_Diagnostics/S12.6.4_D1.html depends on undefined behavior
https://bugs.webkit.org/show_bug.cgi?id=135007
Reviewed by Filip Pizlo.
EcmaScript 5.1 specifies that during for-in enumeration newly added properties may or may not be
visited during the current enumeration. Specifically, in section 12.6.4 the spec states:
"If new properties are added to the object being enumerated during enumeration, the newly added properties
are not guaranteed to be visited in the active enumeration."
The sputnik/Implementation_Diagnostics/S12.6.4_D1.html layout test is from before sputnik was added
to the test262 suite. I believe it has since been removed, so it would probably be okay to remove it
from our layout test suite.
* sputnik/Implementation_Diagnostics/S12.6.4_D1-expected.txt: Removed.
* sputnik/Implementation_Diagnostics/S12.6.4_D1.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: branches/ftlopt/LayoutTests/ChangeLog (171188 => 171189)
--- branches/ftlopt/LayoutTests/ChangeLog 2014-07-17 17:35:35 UTC (rev 171188)
+++ branches/ftlopt/LayoutTests/ChangeLog 2014-07-17 17:43:31 UTC (rev 171189)
@@ -1,3 +1,23 @@
+2014-07-16 Mark Hahnenberg <[email protected]>
+
+ sputnik/Implementation_Diagnostics/S12.6.4_D1.html depends on undefined behavior
+ https://bugs.webkit.org/show_bug.cgi?id=135007
+
+ Reviewed by Filip Pizlo.
+
+ EcmaScript 5.1 specifies that during for-in enumeration newly added properties may or may not be
+ visited during the current enumeration. Specifically, in section 12.6.4 the spec states:
+
+ "If new properties are added to the object being enumerated during enumeration, the newly added properties
+ are not guaranteed to be visited in the active enumeration."
+
+ The sputnik/Implementation_Diagnostics/S12.6.4_D1.html layout test is from before sputnik was added
+ to the test262 suite. I believe it has since been removed, so it would probably be okay to remove it
+ from our layout test suite.
+
+ * sputnik/Implementation_Diagnostics/S12.6.4_D1-expected.txt: Removed.
+ * sputnik/Implementation_Diagnostics/S12.6.4_D1.html: Removed.
+
2014-07-13 Filip Pizlo <[email protected]>
[ftlopt] DFG should be able to do GCSE in SSA and this should be unified with the CSE in CPS, and both of these things should use abstract heaps for reasoning about effects
Deleted: branches/ftlopt/LayoutTests/sputnik/Implementation_Diagnostics/S12.6.4_D1-expected.txt (171188 => 171189)
--- branches/ftlopt/LayoutTests/sputnik/Implementation_Diagnostics/S12.6.4_D1-expected.txt 2014-07-17 17:35:35 UTC (rev 171188)
+++ branches/ftlopt/LayoutTests/sputnik/Implementation_Diagnostics/S12.6.4_D1-expected.txt 2014-07-17 17:43:31 UTC (rev 171189)
@@ -1,6 +0,0 @@
-S12.6.4_D1
-
-FAIL SputnikError: #1: the newly added properties to be visited in the active enumeration
-
-TEST COMPLETE
-
Deleted: branches/ftlopt/LayoutTests/sputnik/Implementation_Diagnostics/S12.6.4_D1.html (171188 => 171189)
--- branches/ftlopt/LayoutTests/sputnik/Implementation_Diagnostics/S12.6.4_D1.html 2014-07-17 17:35:35 UTC (rev 171188)
+++ branches/ftlopt/LayoutTests/sputnik/Implementation_Diagnostics/S12.6.4_D1.html 2014-07-17 17:43:31 UTC (rev 171189)
@@ -1,130 +0,0 @@
-<html>
-<head>
-<meta charset='utf-8'>
-<style>
-.pass {
- font-weight: bold;
- color: green;
-}
-.fail {
- font-weight: bold;
- color: red;
-}
-</style>
-
-<script>
-if (window.testRunner)
- testRunner.dumpAsText();
-
-function SputnikError(message)
-{
- this.message = message;
-}
-
-SputnikError.prototype.toString = function ()
-{
- return 'SputnikError: ' + this.message;
-};
-
-var sputnikException;
-
-function testPrint(msg)
-{
- var span = document.createElement("span");
- document.getElementById("console").appendChild(span); // insert it first so XHTML knows the namespace
- span.innerHTML = msg + '<br />';
-}
-
-function escapeHTML(text)
-{
- return text.toString().replace(/&/g, "&").replace(/</g, "<");
-}
-
-function printTestPassed(msg)
-{
- testPrint('<span><span class="pass">PASS</span> ' + escapeHTML(msg) + '</span>');
-}
-
-function printTestFailed(msg)
-{
- testPrint('<span><span class="fail">FAIL</span> ' + escapeHTML(msg) + '</span>');
-}
-
-function testFailed(msg)
-{
- throw new SputnikError(msg);
-}
-
-var successfullyParsed = false;
-</script>
-
-</head>
-<body>
-<p>S12.6.4_D1</p>
-<div id='console'></div>
-<script>
-try {
-
-/**
-* @name: S12.6.4_D1;
-* @section: 12.6.4;
-* @assertion: If new properties are added to the object being
-* enumerated during enumeration, the newly added properties to be visited in the active
-* enumeration;
-*/
-
-__obj={aa:1,ba:2,ca:3};
-__source={sra:9,srb:8,src:7};
-
-__accum="";
-
-for (__key in __obj){
-
- __accum+=(__key+__obj[__key]);
-
- add2hash(__obj,__source);
-
-}
-
-
-//////////////////////////////////////////////////////////////////////////////
-//CHECK#1
-if (!(
-(__accum.indexOf("aa1")!==-1)&&
-(__accum.indexOf("ba2")!==-1)&&
-(__accum.indexOf("ca3")!==-1)&&
-(__accum.indexOf("sra9")!==-1)&&
-(__accum.indexOf("srb8")!==-1)&&
-(__accum.indexOf("src7")!==-1)
-)) {
- testFailed('#1: the newly added properties to be visited in the active enumeration');
-}
-//
-//////////////////////////////////////////////////////////////////////////////
-
-function add2hash(hash_map_target, hash_map_be_added){
- if (added) return;
- for (key in hash_map_be_added){
- hash_map_target[key] = hash_map_be_added[key];
- }
- var added = true;
-}
-
-} catch (ex) {
- sputnikException = ex;
-}
-
-var successfullyParsed = true;
-</script>
-
-<script>
-if (!successfullyParsed)
- printTestFailed('successfullyParsed is not set');
-else if (sputnikException)
- printTestFailed(sputnikException);
-else
- printTestPassed("");
-testPrint('<br /><span class="pass">TEST COMPLETE</span>');
-</script>
-</body>
-</html>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
