Title: [171197] trunk/Source/WebKit2
- Revision
- 171197
- Author
- [email protected]
- Date
- 2014-07-17 14:27:56 -0700 (Thu, 17 Jul 2014)
Log Message
[Mac] Full screen video not always animating in the correct Space
https://bugs.webkit.org/show_bug.cgi?id=135020
<rdar://problem/17542310>
Reviewed by Dean Jackson.
The fullscreen window can "remember" the Space it was part of the first time you enter fullscreen
mode. Subsequent fullscreen transitions will always start from this Space, even if you move
the WebKit-hosted application to a different Space.
We can help the display system know when we've moved to a new Space by calling NSWindow's
'orderBack' method on the fullscreen window prior to starting the transition to fullscreen mode.
This method call hooks the window into the current Space so everything works properly.
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): Add the
new fullscreen window to the current Space before starting transition to fullscreen.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (171196 => 171197)
--- trunk/Source/WebKit2/ChangeLog 2014-07-17 21:27:00 UTC (rev 171196)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-17 21:27:56 UTC (rev 171197)
@@ -1,3 +1,23 @@
+2014-07-17 Brent Fulgham <[email protected]>
+
+ [Mac] Full screen video not always animating in the correct Space
+ https://bugs.webkit.org/show_bug.cgi?id=135020
+ <rdar://problem/17542310>
+
+ Reviewed by Dean Jackson.
+
+ The fullscreen window can "remember" the Space it was part of the first time you enter fullscreen
+ mode. Subsequent fullscreen transitions will always start from this Space, even if you move
+ the WebKit-hosted application to a different Space.
+
+ We can help the display system know when we've moved to a new Space by calling NSWindow's
+ 'orderBack' method on the fullscreen window prior to starting the transition to fullscreen mode.
+ This method call hooks the window into the current Space so everything works properly.
+
+ * UIProcess/mac/WKFullScreenWindowController.mm:
+ (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): Add the
+ new fullscreen window to the current Space before starting transition to fullscreen.
+
2014-07-17 Timothy Hatcher <[email protected]>
Make console.profile record to the Timeline.
Modified: trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm (171196 => 171197)
--- trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm 2014-07-17 21:27:00 UTC (rev 171196)
+++ trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm 2014-07-17 21:27:56 UTC (rev 171197)
@@ -267,6 +267,7 @@
if (!_backgroundWindow)
_backgroundWindow = createBackgroundFullscreenWindow(NSZeroRect);
+ [self.window orderBack: self]; // Make sure the full screen window is part of the correct Space.
[[self window] enterFullScreenMode:self];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
