Title: [171204] trunk/Source/_javascript_Core
- Revision
- 171204
- Author
- [email protected]
- Date
- 2014-07-17 16:30:36 -0700 (Thu, 17 Jul 2014)
Log Message
Follow-up fix to r171195 to prevent ASSERT in fast/profiler/profile-with-no-title.html
Rubber-stamped by Alexey Proskuryakov.
Null / empty titles should be fine. Tests pass in release builds
which allowed empty titles, and it looks like the LegacyProfiler
stopProfiling handles empty titles as expected already.
* profiler/LegacyProfiler.cpp:
(JSC::LegacyProfiler::startProfiling):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (171203 => 171204)
--- trunk/Source/_javascript_Core/ChangeLog 2014-07-17 22:46:20 UTC (rev 171203)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-07-17 23:30:36 UTC (rev 171204)
@@ -1,3 +1,16 @@
+2014-07-17 Joseph Pecoraro <[email protected]>
+
+ Follow-up fix to r171195 to prevent ASSERT in fast/profiler/profile-with-no-title.html
+
+ Rubber-stamped by Alexey Proskuryakov.
+
+ Null / empty titles should be fine. Tests pass in release builds
+ which allowed empty titles, and it looks like the LegacyProfiler
+ stopProfiling handles empty titles as expected already.
+
+ * profiler/LegacyProfiler.cpp:
+ (JSC::LegacyProfiler::startProfiling):
+
2014-07-16 Filip Pizlo <[email protected]>
DFG Flush(SetLocal) store elimination is overzealous for captured variables in the presence of nodes that have no effects but may throw
Modified: trunk/Source/_javascript_Core/profiler/LegacyProfiler.cpp (171203 => 171204)
--- trunk/Source/_javascript_Core/profiler/LegacyProfiler.cpp 2014-07-17 22:46:20 UTC (rev 171203)
+++ trunk/Source/_javascript_Core/profiler/LegacyProfiler.cpp 2014-07-17 23:30:36 UTC (rev 171204)
@@ -60,8 +60,6 @@
void LegacyProfiler::startProfiling(ExecState* exec, const String& title)
{
- ASSERT_ARG(title, !title.isNull());
-
if (!exec)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
