Title: [171216] trunk/Tools
- Revision
- 171216
- Author
- [email protected]
- Date
- 2014-07-18 00:11:11 -0700 (Fri, 18 Jul 2014)
Log Message
Unreviewed, fix build for platforms that don't have ShellQuote.
* Scripts/jsc-stress-test-helpers/js-exception-fuzz: Take a single argument that has the whole command string.
* Scripts/run-jsc-stress-tests: Do the escaping in Ruby.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (171215 => 171216)
--- trunk/Tools/ChangeLog 2014-07-18 06:16:56 UTC (rev 171215)
+++ trunk/Tools/ChangeLog 2014-07-18 07:11:11 UTC (rev 171216)
@@ -1,3 +1,10 @@
+2014-07-18 Filip Pizlo <[email protected]>
+
+ Unreviewed, fix build for platforms that don't have ShellQuote.
+
+ * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Take a single argument that has the whole command string.
+ * Scripts/run-jsc-stress-tests: Do the escaping in Ruby.
+
2014-07-15 Filip Pizlo <[email protected]>
Need ability to fuzz exception throwing
Modified: trunk/Tools/Scripts/jsc-stress-test-helpers/js-exception-fuzz (171215 => 171216)
--- trunk/Tools/Scripts/jsc-stress-test-helpers/js-exception-fuzz 2014-07-18 06:16:56 UTC (rev 171215)
+++ trunk/Tools/Scripts/jsc-stress-test-helpers/js-exception-fuzz 2014-07-18 07:11:11 UTC (rev 171216)
@@ -57,7 +57,7 @@
'verbose' => \$verbose
);
-my $commandString = shell_quote @ARGV;
+my $commandString = shift @ARGV;
my $checkCount;
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (171215 => 171216)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2014-07-18 06:16:56 UTC (rev 171215)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2014-07-18 07:11:11 UTC (rev 171216)
@@ -74,6 +74,14 @@
raise "Command failed: #{$?.inspect}" unless system(*cmd)
end
+def escapeAll(array)
+ array.map {
+ | v |
+ raise "Detected a non-string in #{inspect}" unless v.is_a? String
+ Shellwords.shellescape(v)
+ }.join(' ')
+end
+
begin
$numProcessors = `sysctl -n hw.activecpu 2>/dev/null`.to_i
rescue
@@ -481,11 +489,7 @@
# It's important to remember that the test is actually run in a subshell, so if we change directory
# in the subshell when we return we will be in our original directory. This is nice because we don't
# have to bend over backwards to do things relative to the root.
- "(cd ../#{Shellwords.shellescape(@directory.to_s)} && \"$@\" " + @arguments.map{
- | v |
- raise "Detected a non-string in #{inspect}" unless v.is_a? String
- Shellwords.shellescape(v)
- }.join(' ') + ")"
+ "(cd ../#{Shellwords.shellescape(@directory.to_s)} && \"$@\" " + escapeAll(@arguments) + ")"
end
def reproScriptCommand
@@ -734,7 +738,8 @@
end
def runExceptionFuzz
- addRunCommand("exception-fuzz", ["perl", (HELPERS_PATH + "js-exception-fuzz").to_s, pathToVM.to_s, $benchmark.to_s], silentOutputHandler, simpleErrorHandler)
+ subCommand = escapeAll([pathToVM.to_s, $benchmark.to_s])
+ addRunCommand("exception-fuzz", ["perl", (HELPERS_PATH + "js-exception-fuzz").to_s, subCommand], silentOutputHandler, simpleErrorHandler)
end
def runLayoutTest(kind, *options)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
