Title: [171257] trunk/Source/WebKit2
Revision
171257
Author
[email protected]
Date
2014-07-18 18:30:35 -0700 (Fri, 18 Jul 2014)

Log Message

We don't provide an extension to the temp file used for uploads
https://bugs.webkit.org/show_bug.cgi?id=135079

Reviewed by Sam Weinig.

Make sure didChooseFilesForOpenPanelWithDisplayStringAndIcon vends
extensions for the files passed to the content process.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (171256 => 171257)


--- trunk/Source/WebKit2/ChangeLog	2014-07-19 00:52:18 UTC (rev 171256)
+++ trunk/Source/WebKit2/ChangeLog	2014-07-19 01:30:35 UTC (rev 171257)
@@ -1,3 +1,16 @@
+2014-07-18  Oliver Hunt  <[email protected]>
+
+        We don't provide an extension to the temp file used for uploads
+        https://bugs.webkit.org/show_bug.cgi?id=135079
+
+        Reviewed by Sam Weinig.
+
+        Make sure didChooseFilesForOpenPanelWithDisplayStringAndIcon vends
+        extensions for the files passed to the content process.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
+
 2014-07-18  Tim Horton  <[email protected]>
 
         ASSERTion failures in ViewGestureController indicating that we're copying WebBackForwardList

Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (171256 => 171257)


--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-07-19 00:52:18 UTC (rev 171256)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-07-19 01:30:35 UTC (rev 171257)
@@ -3775,6 +3775,16 @@
     if (!isValid())
         return;
 
+#if ENABLE(SANDBOX_EXTENSIONS)
+    // FIXME: The sandbox extensions should be sent with the DidChooseFilesForOpenPanel message. This
+    // is gated on a way of passing SandboxExtension::Handles in a Vector.
+    for (size_t i = 0; i < fileURLs.size(); ++i) {
+        SandboxExtension::Handle sandboxExtensionHandle;
+        SandboxExtension::createHandle(fileURLs[i], SandboxExtension::ReadOnly, sandboxExtensionHandle);
+        m_process->send(Messages::WebPage::ExtendSandboxForFileFromOpenPanel(sandboxExtensionHandle), m_pageID);
+    }
+#endif
+
     m_process->send(Messages::WebPage::DidChooseFilesForOpenPanelWithDisplayStringAndIcon(fileURLs, displayString, iconData ? iconData->dataReference() : IPC::DataReference()), m_pageID);
 
     m_openPanelResultListener->invalidate();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to