Title: [171277] trunk/Tools
- Revision
- 171277
- Author
- [email protected]
- Date
- 2014-07-20 08:08:06 -0700 (Sun, 20 Jul 2014)
Log Message
Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
<http://webkit.org/b/135096>
Reviewed by Alexey Proskuryakov.
* DumpRenderTree/mac/LayoutTestHelper.m:
(lockDownDiscreteGraphics): Check the return values of
IOServiceOpen() and IOObjectRelease(), and log if not
KERN_SUCCESS.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (171276 => 171277)
--- trunk/Tools/ChangeLog 2014-07-20 04:32:27 UTC (rev 171276)
+++ trunk/Tools/ChangeLog 2014-07-20 15:08:06 UTC (rev 171277)
@@ -1,3 +1,15 @@
+2014-07-20 David Kilzer <[email protected]>
+
+ Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
+ <http://webkit.org/b/135096>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * DumpRenderTree/mac/LayoutTestHelper.m:
+ (lockDownDiscreteGraphics): Check the return values of
+ IOServiceOpen() and IOObjectRelease(), and log if not
+ KERN_SUCCESS.
+
2014-07-19 Anders Carlsson <[email protected]>
Update.
Modified: trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m (171276 => 171277)
--- trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m 2014-07-20 04:32:27 UTC (rev 171276)
+++ trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m 2014-07-20 15:08:06 UTC (rev 171277)
@@ -162,7 +162,14 @@
// This call stalls until the graphics device lock is granted.
kernResult = IOServiceOpen(serviceObject, mach_task_self(), 1, &permanentLockDownService);
- IOObjectRelease(serviceObject);
+ if (kernResult != KERN_SUCCESS) {
+ NSLog(@"IOServiceOpen() failed in %s with kernResult = %d", __FUNCTION__, kernResult);
+ return;
+ }
+
+ kernResult = IOObjectRelease(serviceObject);
+ if (kernResult != KERN_SUCCESS)
+ NSLog(@"IOObjectRelease() failed in %s with kernResult = %d", __FUNCTION__, kernResult);
}
int main(int argc, char* argv[])
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
