Title: [171279] trunk/Source/WebCore
- Revision
- 171279
- Author
- [email protected]
- Date
- 2014-07-20 09:45:34 -0700 (Sun, 20 Jul 2014)
Log Message
[iOS] ignore requests to set volume
https://bugs.webkit.org/show_bug.cgi?id=135081
Applied post-review comments from Darin Adler.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume): Don't include unreachable
code on iOS.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (171278 => 171279)
--- trunk/Source/WebCore/ChangeLog 2014-07-20 16:16:57 UTC (rev 171278)
+++ trunk/Source/WebCore/ChangeLog 2014-07-20 16:45:34 UTC (rev 171279)
@@ -1,3 +1,14 @@
+2014-07-20 Eric Carlson <[email protected]>
+
+ [iOS] ignore requests to set volume
+ https://bugs.webkit.org/show_bug.cgi?id=135081
+
+ Applied post-review comments from Darin Adler.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume): Don't include unreachable
+ code on iOS.
+
2014-07-19 Mark Rowe <[email protected]>
<https://webkit.org/b/135085> Ensure that make_names.pl generates the same result when run multiple times.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (171278 => 171279)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-07-20 16:16:57 UTC (rev 171278)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-07-20 16:45:34 UTC (rev 171279)
@@ -1127,13 +1127,14 @@
void MediaPlayerPrivateAVFoundationObjC::setVolume(float volume)
{
#if PLATFORM(IOS)
+ UNUSED_PARAM(volume);
return;
-#endif
-
+#else
if (!metaDataAvailable())
return;
[m_avPlayer.get() setVolume:volume];
+#endif
}
void MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible(bool closedCaptionsVisible)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
