Title: [171326] trunk/Source/WebKit2
Revision
171326
Author
[email protected]
Date
2014-07-21 17:38:38 -0700 (Mon, 21 Jul 2014)

Log Message

Remove global cookie workaround from sandbox profiles
https://bugs.webkit.org/show_bug.cgi?id=135138
<rdar://17513375>

Reviewed by Alexey Proskuryakov.

Remove the workaround needed for global cookie access, and silencing
of the associated sandbox violation.

* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultCookieStorageDirectory):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (171325 => 171326)


--- trunk/Source/WebKit2/ChangeLog	2014-07-22 00:37:13 UTC (rev 171325)
+++ trunk/Source/WebKit2/ChangeLog	2014-07-22 00:38:38 UTC (rev 171326)
@@ -1,5 +1,21 @@
 2014-07-21  Oliver Hunt  <[email protected]>
 
+        Remove global cookie workaround from sandbox profiles
+        https://bugs.webkit.org/show_bug.cgi?id=135138
+        <rdar://17513375>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Remove the workaround needed for global cookie access, and silencing
+        of the associated sandbox violation.
+
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+        * UIProcess/mac/WebContextMac.mm:
+        (WebKit::WebContext::platformDefaultCookieStorageDirectory):
+
+2014-07-21  Oliver Hunt  <[email protected]>
+
         Correct sandbox profiles to fix some excess privileges
         https://bugs.webkit.org/show_bug.cgi?id=135134
         <rdar://problem/17741886>

Modified: trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb (171325 => 171326)


--- trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb	2014-07-22 00:37:13 UTC (rev 171325)
+++ trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb	2014-07-22 00:38:38 UTC (rev 171326)
@@ -28,10 +28,6 @@
 (import "common.sb")
 (import "removed-dev-nodes.sb")
 
-;; Access CFNetwork shared cookies
-;; This is too generous -- <rdar://problem/17496756>
-(apple-cookie-access 'with-read-write)
-
 ;; Sandbox extensions
 (allow file-read* (extension "com.apple.webkit.read"))
 

Modified: trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (171325 => 171326)


--- trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2014-07-22 00:37:13 UTC (rev 171325)
+++ trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2014-07-22 00:38:38 UTC (rev 171326)
@@ -32,10 +32,6 @@
 (apple-ui-app "com.apple.WebKit.WebContent" 'with-opengl)
 (opengl)
 
-;; Access CFNetwork shared cookies
-;; This is too generous -- <rdar://problem/17496756>
-(apple-cookie-access 'with-read-write)
-
 ;; Access to media controls
 (play-media)
 (media-remote)

Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (171325 => 171326)


--- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2014-07-22 00:37:13 UTC (rev 171325)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2014-07-22 00:38:38 UTC (rev 171326)
@@ -277,10 +277,6 @@
 
     path = path + "/Library/Cookies";
     path = stringByResolvingSymlinksInPath(path);
-    // Temporary work around for <rdar://<rdar://problem/17513375>
-    if (path == "/private/var/mobile/Library/Cookies")
-        return String();
-
     return path;
 #else
     notImplemented();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to