Title: [171407] branches/safari-600.1-branch/Source/WebKit2
Revision
171407
Author
dburk...@apple.com
Date
2014-07-22 22:31:21 -0700 (Tue, 22 Jul 2014)

Log Message

Merge r171197

Modified Paths

Diff

Modified: branches/safari-600.1-branch/Source/WebKit2/ChangeLog (171406 => 171407)


--- branches/safari-600.1-branch/Source/WebKit2/ChangeLog	2014-07-23 05:28:55 UTC (rev 171406)
+++ branches/safari-600.1-branch/Source/WebKit2/ChangeLog	2014-07-23 05:31:21 UTC (rev 171407)
@@ -1,5 +1,29 @@
 2014-07-22 Dana Burkart <dburk...@apple.com>
     
+        Merge r171197.
+
+    2014-07-17  Brent Fulgham  <bfulg...@apple.com>
+
+            [Mac] Full screen video not always animating in the correct Space
+            https://bugs.webkit.org/show_bug.cgi?id=135020
+            <rdar://problem/17542310>
+
+            Reviewed by Dean Jackson.
+
+           The fullscreen window can "remember" the Space it was part of the first time you enter fullscreen
+           mode. Subsequent fullscreen transitions will always start from this Space, even if you move
+           the WebKit-hosted application to a different Space.
+
+           We can help the display system know when we've moved to a new Space by calling NSWindow's
+           'orderBack' method on the fullscreen window prior to starting the transition to fullscreen mode.
+           This method call hooks the window into the current Space so everything works properly.
+
+            * UIProcess/mac/WKFullScreenWindowController.mm:
+            (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): Add the
+            new fullscreen window to the current Space before starting transition to fullscreen.
+
+2014-07-22 Dana Burkart <dburk...@apple.com>
+    
         Merge r171195.
 
     2014-07-17  Timothy Hatcher  <timo...@apple.com>

Modified: branches/safari-600.1-branch/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm (171406 => 171407)


--- branches/safari-600.1-branch/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm	2014-07-23 05:28:55 UTC (rev 171406)
+++ branches/safari-600.1-branch/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm	2014-07-23 05:31:21 UTC (rev 171407)
@@ -267,6 +267,7 @@
     if (!_backgroundWindow)
         _backgroundWindow = createBackgroundFullscreenWindow(NSZeroRect);
 
+    [self.window orderBack: self]; // Make sure the full screen window is part of the correct Space.
     [[self window] enterFullScreenMode:self];
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to