Title: [171570] trunk/Source/WebKit2
Revision
171570
Author
timothy_hor...@apple.com
Date
2014-07-24 18:11:24 -0700 (Thu, 24 Jul 2014)

Log Message

Sometimes WKWebView is blank after resuming the app, until you scroll
https://bugs.webkit.org/show_bug.cgi?id=135275
<rdar://problem/17803170>

Reviewed by Benjamin Poulain.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dispatchViewStateChange):
If the UI process is waiting for a didUpdateViewState, we need to *always*
get a reply from the Web Process, so dispatchViewStateChange should *always*
send SetViewState even if nothing changed (so that we get the reply).

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (171569 => 171570)


--- trunk/Source/WebKit2/ChangeLog	2014-07-25 01:08:28 UTC (rev 171569)
+++ trunk/Source/WebKit2/ChangeLog	2014-07-25 01:11:24 UTC (rev 171570)
@@ -1,3 +1,17 @@
+2014-07-24  Tim Horton  <timothy_hor...@apple.com>
+
+        Sometimes WKWebView is blank after resuming the app, until you scroll
+        https://bugs.webkit.org/show_bug.cgi?id=135275
+        <rdar://problem/17803170>
+
+        Reviewed by Benjamin Poulain.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::dispatchViewStateChange):
+        If the UI process is waiting for a didUpdateViewState, we need to *always*
+        get a reply from the Web Process, so dispatchViewStateChange should *always*
+        send SetViewState even if nothing changed (so that we get the reply).
+
 2014-07-24  Simon Fraser  <simon.fra...@apple.com>
 
         [iOS WK2] Header bar on nytimes articles lands in the wrong place after rubberbanding

Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (171569 => 171570)


--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-07-25 01:08:28 UTC (rev 171569)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-07-25 01:11:24 UTC (rev 171570)
@@ -1188,7 +1188,7 @@
     if (m_viewWasEverInWindow && (changed & ViewState::IsInWindow) && isInWindow())
         m_viewStateChangeWantsReply = true;
 
-    if (changed)
+    if (changed || m_viewStateChangeWantsReply)
         m_process->send(Messages::WebPage::SetViewState(m_viewState, m_viewStateChangeWantsReply), m_pageID);
 
     // This must happen after the SetViewState message is sent, to ensure the page visibility event can fire.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to