Title: [171599] trunk/Source/WebCore
- Revision
- 171599
- Author
- [email protected]
- Date
- 2014-07-25 09:39:59 -0700 (Fri, 25 Jul 2014)
Log Message
[Cocoa] WebProtectionSpace::receivesCredentialSecurely incorrectly returns false in some cases
https://bugs.webkit.org/show_bug.cgi?id=135241
Reviewed by Alexey Proskuryakov.
* WebCore.exp.in: Export ProtectionSpace::receivesCredentialSecurely.
* platform/network/cocoa/ProtectionSpaceCocoa.h: Declare override of receivesCredentialSecurely.
* platform/network/cocoa/ProtectionSpaceCocoa.mm:
(WebCore::ProtectionSpace::receivesCredentialSecurely): Use -[NSURLProtectionSpace receivesCredentialSecurely].
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (171598 => 171599)
--- trunk/Source/WebCore/ChangeLog 2014-07-25 16:18:17 UTC (rev 171598)
+++ trunk/Source/WebCore/ChangeLog 2014-07-25 16:39:59 UTC (rev 171599)
@@ -1,3 +1,16 @@
+2014-07-25 Dan Bernstein <[email protected]>
+
+ [Cocoa] WebProtectionSpace::receivesCredentialSecurely incorrectly returns false in some cases
+ https://bugs.webkit.org/show_bug.cgi?id=135241
+
+ Reviewed by Alexey Proskuryakov.
+
+ * WebCore.exp.in: Export ProtectionSpace::receivesCredentialSecurely.
+
+ * platform/network/cocoa/ProtectionSpaceCocoa.h: Declare override of receivesCredentialSecurely.
+ * platform/network/cocoa/ProtectionSpaceCocoa.mm:
+ (WebCore::ProtectionSpace::receivesCredentialSecurely): Use -[NSURLProtectionSpace receivesCredentialSecurely].
+
2014-07-25 Zalan Bujtas <[email protected]>
Subpixel rendering: iOS video playback controls look blurry.
Modified: trunk/Source/WebCore/WebCore.exp.in (171598 => 171599)
--- trunk/Source/WebCore/WebCore.exp.in 2014-07-25 16:18:17 UTC (rev 171598)
+++ trunk/Source/WebCore/WebCore.exp.in 2014-07-25 16:39:59 UTC (rev 171599)
@@ -1742,6 +1742,7 @@
__ZNK7WebCore15GraphicsLayerCA49platformCALayerContentsScaleMultiplierForNewTilesEPNS_15PlatformCALayerE
__ZNK7WebCore15GraphicsLayerCA49platformCALayerShouldTemporarilyRetainTileCohortsEPNS_15PlatformCALayerE
__ZNK7WebCore15ProgressTracker17estimatedProgressEv
+__ZNK7WebCore15ProtectionSpace26receivesCredentialSecurelyEv
__ZNK7WebCore15ProtectionSpace7nsSpaceEv
__ZNK7WebCore15ResourceRequest12cfURLRequestENS_20HTTPBodyUpdatePolicyE
__ZNK7WebCore15ResourceRequest12nsURLRequestENS_20HTTPBodyUpdatePolicyE
@@ -1803,7 +1804,6 @@
__ZNK7WebCore19MediaSessionManager30applicationWillEnterForegroundEv
__ZNK7WebCore19ProtectionSpaceBase10serverTypeEv
__ZNK7WebCore19ProtectionSpaceBase20authenticationSchemeEv
-__ZNK7WebCore19ProtectionSpaceBase26receivesCredentialSecurelyEv
__ZNK7WebCore19ProtectionSpaceBase4hostEv
__ZNK7WebCore19ProtectionSpaceBase4portEv
__ZNK7WebCore19ProtectionSpaceBase5realmEv
Modified: trunk/Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h (171598 => 171599)
--- trunk/Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h 2014-07-25 16:18:17 UTC (rev 171598)
+++ trunk/Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h 2014-07-25 16:39:59 UTC (rev 171599)
@@ -58,6 +58,8 @@
bool encodingRequiresPlatformData() const { return m_nsSpace && encodingRequiresPlatformData(m_nsSpace.get()); }
#endif
+ bool receivesCredentialSecurely() const;
+
#if USE(CFNETWORK)
CFURLProtectionSpaceRef cfSpace() const;
#endif
Modified: trunk/Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm (171598 => 171599)
--- trunk/Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm 2014-07-25 16:18:17 UTC (rev 171598)
+++ trunk/Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm 2014-07-25 16:39:59 UTC (rev 171599)
@@ -195,6 +195,11 @@
return [a.nsSpace() isEqual:b.nsSpace()];
}
+bool ProtectionSpace::receivesCredentialSecurely() const
+{
+ return nsSpace().receivesCredentialSecurely;
+}
+
#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
bool ProtectionSpace::encodingRequiresPlatformData(NSURLProtectionSpace *space)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
