Title: [171673] trunk/Source/WebKit
Revision
171673
Author
psola...@apple.com
Date
2014-07-27 23:50:21 -0700 (Sun, 27 Jul 2014)

Log Message

Remove unused preference keys
https://bugs.webkit.org/show_bug.cgi?id=135280

Reviewed by Darin Adler.

Source/WebKit/mac:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences _setPageCacheSize:]): Deleted.
(-[WebPreferences _pageCacheSize]): Deleted.
(-[WebPreferences _setObjectCacheSize:]): Deleted.
(-[WebPreferences _objectCacheSize]): Deleted.
* WebView/WebPreferencesPrivate.h:

Source/WebKit/win:
* WebPreferenceKeysPrivate.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (171672 => 171673)


--- trunk/Source/WebKit/mac/ChangeLog	2014-07-28 06:47:28 UTC (rev 171672)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-07-28 06:50:21 UTC (rev 171673)
@@ -1,3 +1,19 @@
+2014-07-27  Pratik Solanki  <psola...@apple.com>
+
+        Remove unused preference keys
+        https://bugs.webkit.org/show_bug.cgi?id=135280
+
+        Reviewed by Darin Adler.
+
+        * WebView/WebPreferenceKeysPrivate.h:
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]):
+        (-[WebPreferences _setPageCacheSize:]): Deleted.
+        (-[WebPreferences _pageCacheSize]): Deleted.
+        (-[WebPreferences _setObjectCacheSize:]): Deleted.
+        (-[WebPreferences _objectCacheSize]): Deleted.
+        * WebView/WebPreferencesPrivate.h:
+
 2014-07-27  Filip Pizlo  <fpi...@apple.com>
 
         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.

Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (171672 => 171673)


--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h	2014-07-28 06:47:28 UTC (rev 171672)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h	2014-07-28 06:50:21 UTC (rev 171673)
@@ -171,9 +171,6 @@
 // default.
 #define WebKitEnableDeferredUpdatesPreferenceKey @"WebKitEnableDeferredUpdates"
 
-// For debugging only. Don't use these.
-#define WebKitPageCacheSizePreferenceKey @"WebKitPageCacheSizePreferenceKey"
-#define WebKitObjectCacheSizePreferenceKey @"WebKitObjectCacheSizePreferenceKey"
 #define WebKitDebugFullPageZoomPreferenceKey @"WebKitDebugFullPageZoomPreferenceKey"
 
 #define WebKitMinimumZoomFontSizePreferenceKey @"WebKitMinimumZoomFontSizePreferenceKey"

Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (171672 => 171673)


--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm	2014-07-28 06:47:28 UTC (rev 171672)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm	2014-07-28 06:50:21 UTC (rev 171673)
@@ -554,7 +554,6 @@
         [NSNumber numberWithInt:-1],      WebKitLayoutIntervalPreferenceKey,
         [NSNumber numberWithFloat:-1.0f], WebKitMaxParseDurationPreferenceKey,
         [NSNumber numberWithBool:NO],     WebKitAllowMultiElementImplicitFormSubmissionPreferenceKey,
-        [NSNumber numberWithInt:-1],      WebKitPageCacheSizePreferenceKey,
         [NSNumber numberWithBool:NO],     WebKitAlwaysRequestGeolocationPermissionPreferenceKey,
         [NSNumber numberWithInt:InterpolationLow], WebKitInterpolationQualityPreferenceKey,
         [NSNumber numberWithBool:YES],    WebKitPasswordEchoEnabledPreferenceKey,
@@ -1446,26 +1445,6 @@
     return [self _floatValueForKey:WebKitMaxParseDurationPreferenceKey];
 }
 
-- (void)_setPageCacheSize:(int)size
-{
-    [self _setIntegerValue:size forKey:WebKitPageCacheSizePreferenceKey];
-}
-
-- (int)_pageCacheSize
-{
-    return [self _integerValueForKey:WebKitPageCacheSizePreferenceKey];
-}
-
-- (void)_setObjectCacheSize:(int)size
-{
-    [self _setIntegerValue:size forKey:WebKitObjectCacheSizePreferenceKey];
-}
-
-- (int)_objectCacheSize
-{
-    return [self _integerValueForKey:WebKitObjectCacheSizePreferenceKey];
-}
-
 - (void)_setAlwaysUseBaselineOfPrimaryFont:(BOOL)flag
 {
     [self _setBoolValue:flag forKey:WebKitAlwaysUseBaselineOfPrimaryFontPreferenceKey];

Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (171672 => 171673)


--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h	2014-07-28 06:47:28 UTC (rev 171672)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h	2014-07-28 06:50:21 UTC (rev 171673)
@@ -308,10 +308,6 @@
 - (int)_layoutInterval;
 - (void)_setMaxParseDuration:(float)d;
 - (float)_maxParseDuration;
-- (void)_setPageCacheSize:(int)size;
-- (int)_pageCacheSize;
-- (void)_setObjectCacheSize:(int)size;
-- (int)_objectCacheSize;
 - (void)_setInterpolationQuality:(int)quality;
 - (int)_interpolationQuality;
 - (BOOL)_allowPasswordEcho;

Modified: trunk/Source/WebKit/win/ChangeLog (171672 => 171673)


--- trunk/Source/WebKit/win/ChangeLog	2014-07-28 06:47:28 UTC (rev 171672)
+++ trunk/Source/WebKit/win/ChangeLog	2014-07-28 06:50:21 UTC (rev 171673)
@@ -1,3 +1,12 @@
+2014-07-27  Pratik Solanki  <psola...@apple.com>
+
+        Remove unused preference keys
+        https://bugs.webkit.org/show_bug.cgi?id=135280
+
+        Reviewed by Darin Adler.
+
+        * WebPreferenceKeysPrivate.h:
+
 2014-07-22  Brent Fulgham  <bfulg...@apple.com>
 
         [Win] Build fix after r171370.

Modified: trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h (171672 => 171673)


--- trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h	2014-07-28 06:47:28 UTC (rev 171672)
+++ trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h	2014-07-28 06:50:21 UTC (rev 171673)
@@ -95,10 +95,6 @@
 // default.
 #define WebKitEnableDeferredUpdatesPreferenceKey "WebKitEnableDeferredUpdates"
 
-// For debugging only.  Don't use these.
-#define WebKitPageCacheSizePreferenceKey "WebKitPageCacheSizePreferenceKey"
-#define WebKitObjectCacheSizePreferenceKey "WebKitObjectCacheSizePreferenceKey"
-
 // From WebHistory.h
 #define WebKitHistoryItemLimitKey "WebKitHistoryItemLimit" // default: "1000"
 #define WebKitHistoryAgeInDaysLimitKey "WebKitHistoryAgeInDaysLimit" // default: "7"
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to