Title: [171893] trunk/Tools
Revision
171893
Author
[email protected]
Date
2014-07-31 15:56:30 -0700 (Thu, 31 Jul 2014)

Log Message

[Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
https://bugs.webkit.org/show_bug.cgi?id=135472

Reviewed by Dan Bernstein.

We now handle server trust challenges, and don't need such hacks.

* WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
(WTR::InjectedBundle::platformInitialize):
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (171892 => 171893)


--- trunk/Tools/ChangeLog	2014-07-31 22:45:00 UTC (rev 171892)
+++ trunk/Tools/ChangeLog	2014-07-31 22:56:30 UTC (rev 171893)
@@ -1,5 +1,19 @@
 2014-07-31  Alexey Proskuryakov  <[email protected]>
 
+        [Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
+        https://bugs.webkit.org/show_bug.cgi?id=135472
+
+        Reviewed by Dan Bernstein.
+
+        We now handle server trust challenges, and don't need such hacks.
+
+        * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
+        (WTR::InjectedBundle::platformInitialize):
+        * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
+        (WTR::InjectedBundle::platformInitialize):
+
+2014-07-31  Alexey Proskuryakov  <[email protected]>
+
         media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
         on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
         https://bugs.webkit.org/show_bug.cgi?id=135418

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm (171892 => 171893)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm	2014-07-31 22:45:00 UTC (rev 171892)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm	2014-07-31 22:56:30 UTC (rev 171893)
@@ -27,10 +27,6 @@
 
 #import <Foundation/Foundation.h>
 
-@interface NSURLRequest (PrivateThingsWeShouldntReallyUse)
-+(void)setAllowsAnyHTTPSCertificate:(BOOL)allow forHost:(NSString *)host;
-@end
-
 namespace WTR {
 
 void InjectedBundle::platformInitialize(WKTypeRef)
@@ -39,9 +35,6 @@
         nil];
 
     [[NSUserDefaults standardUserDefaults] setVolatileDomain:dict forName:NSArgumentDomain];
-
-    [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"localhost"];
-    [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"127.0.0.1"];
 }
 
 } // namespace WTR

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm (171892 => 171893)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm	2014-07-31 22:45:00 UTC (rev 171892)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm	2014-07-31 22:56:30 UTC (rev 171893)
@@ -27,10 +27,6 @@
 
 #import <Foundation/Foundation.h>
 
-@interface NSURLRequest (PrivateThingsWeShouldntReallyUse)
-+(void)setAllowsAnyHTTPSCertificate:(BOOL)allow forHost:(NSString *)host;
-@end
-
 @interface NSSound (Details)
 + (void)_setAlertType:(NSUInteger)alertType;
 @end
@@ -70,9 +66,6 @@
     // A distributed notification is delivered to all applications, but it should be harmless, and it's the only way to update all underlying frameworks anyway.
     [[NSDistributedNotificationCenter defaultCenter] postNotificationName:@"AppleAquaAntiAliasingChanged" object:nil userInfo:nil deliverImmediately:YES];
 
-    [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"localhost"];
-    [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"127.0.0.1"];
-
     [NSSound _setAlertType:0];
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to