Title: [171897] trunk
- Revision
- 171897
- Author
- [email protected]
- Date
- 2014-07-31 17:15:16 -0700 (Thu, 31 Jul 2014)
Log Message
MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
https://bugs.webkit.org/show_bug.cgi?id=135482
Reviewed by Simon Fraser.
Source/WebKit2:
Add accessors for the missing Fullscreen API so that MiniBrowser
can use them.
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _fullScreenIsEnabled]): Added.
(-[WKPreferences _setFullScreenEnabled:]): Added.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h: Add accessor for
Fullscreen mode.
Tools:
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
feature.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (171896 => 171897)
--- trunk/Source/WebKit2/ChangeLog 2014-07-31 23:55:31 UTC (rev 171896)
+++ trunk/Source/WebKit2/ChangeLog 2014-08-01 00:15:16 UTC (rev 171897)
@@ -1,3 +1,19 @@
+2014-07-31 Brent Fulgham <[email protected]>
+
+ MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
+ https://bugs.webkit.org/show_bug.cgi?id=135482
+
+ Reviewed by Simon Fraser.
+
+ Add accessors for the missing Fullscreen API so that MiniBrowser
+ can use them.
+
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences _fullScreenIsEnabled]): Added.
+ (-[WKPreferences _setFullScreenEnabled:]): Added.
+ * UIProcess/API/Cocoa/WKPreferencesPrivate.h: Add accessor for
+ Fullscreen mode.
+
2014-07-31 Beth Dakin <[email protected]>
Hit-testing broken in WebKit 1 views with AppKit's contentInsets
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm (171896 => 171897)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2014-07-31 23:55:31 UTC (rev 171896)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2014-08-01 00:15:16 UTC (rev 171897)
@@ -163,6 +163,16 @@
_preferences->setOfflineWebApplicationCacheEnabled(offlineApplicationCacheIsEnabled);
}
+- (BOOL)_fullScreenIsEnabled
+{
+ return _preferences->fullScreenEnabled();
+}
+
+- (void)_setFullScreenEnabled:(BOOL)fullScreenEnabled
+{
+ _preferences->setFullScreenEnabled(fullScreenEnabled);
+}
+
- (BOOL)_compositingBordersVisible
{
return _preferences->compositingBordersVisible();
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h (171896 => 171897)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2014-07-31 23:55:31 UTC (rev 171896)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2014-08-01 00:15:16 UTC (rev 171897)
@@ -50,6 +50,7 @@
// FIXME: This should be configured on the WKWebsiteDataStore.
// FIXME: This property should not have the verb "is" in it.
@property (nonatomic, setter=_setOfflineApplicationCacheIsEnabled:) BOOL _offlineApplicationCacheIsEnabled;
+@property (nonatomic, setter=_setFullScreenEnabled:) BOOL _fullScreenIsEnabled;
@end
Modified: trunk/Tools/ChangeLog (171896 => 171897)
--- trunk/Tools/ChangeLog 2014-07-31 23:55:31 UTC (rev 171896)
+++ trunk/Tools/ChangeLog 2014-08-01 00:15:16 UTC (rev 171897)
@@ -1,3 +1,14 @@
+2014-07-31 Brent Fulgham <[email protected]>
+
+ MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
+ https://bugs.webkit.org/show_bug.cgi?id=135482
+
+ Reviewed by Simon Fraser.
+
+ * MiniBrowser/mac/WK2BrowserWindowController.m:
+ (-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
+ feature.
+
2014-07-31 Alexey Proskuryakov <[email protected]>
[Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
Modified: trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m (171896 => 171897)
--- trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2014-07-31 23:55:31 UTC (rev 171896)
+++ trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2014-08-01 00:15:16 UTC (rev 171897)
@@ -59,6 +59,7 @@
configuration.preferences._tiledScrollingIndicatorVisible = [self tiledScrollingIndicatorVisible];
configuration.preferences._compositingBordersVisible = [self layerBordersVisible];
configuration.preferences._compositingRepaintCountersVisible = [self layerBordersVisible];
+ configuration.preferences._fullScreenIsEnabled = YES;
}
_webView = [[WKWebView alloc] initWithFrame:[containerView bounds] configuration:configuration];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
