Title: [172026] trunk/Source/WebCore
- Revision
- 172026
- Author
- [email protected]
- Date
- 2014-08-04 20:58:28 -0700 (Mon, 04 Aug 2014)
Log Message
[MSE][Mac] Seeking past buffered range will not resume playback when seek completes.
https://bugs.webkit.org/show_bug.cgi?id=135591
Reviewed by Eric Carlson.
If a seek is delayed due to seeking into an unbuffered area, playback will not be restarted
at that point. Instead, playback must resume when enough media data has been added, and
the MediaSource indicates the seek should complete.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekCompleted):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (172025 => 172026)
--- trunk/Source/WebCore/ChangeLog 2014-08-05 03:57:27 UTC (rev 172025)
+++ trunk/Source/WebCore/ChangeLog 2014-08-05 03:58:28 UTC (rev 172026)
@@ -1,5 +1,19 @@
2014-08-04 Jer Noble <[email protected]>
+ [MSE][Mac] Seeking past buffered range will not resume playback when seek completes.
+ https://bugs.webkit.org/show_bug.cgi?id=135591
+
+ Reviewed by Eric Carlson.
+
+ If a seek is delayed due to seeking into an unbuffered area, playback will not be restarted
+ at that point. Instead, playback must resume when enough media data has been added, and
+ the MediaSource indicates the seek should complete.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekCompleted):
+
+2014-08-04 Jer Noble <[email protected]>
+
[MSE] Videos will report a stall when within 1 frame-duration before the end of a movie.
https://bugs.webkit.org/show_bug.cgi?id=135586
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (172025 => 172026)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2014-08-05 03:57:27 UTC (rev 172025)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2014-08-05 03:58:28 UTC (rev 172026)
@@ -489,6 +489,8 @@
return;
LOG(MediaSource, "MediaPlayerPrivateMediaSourceAVFObjC::seekCompleted(%p)", this);
m_seekCompleted = true;
+ if (shouldBePlaying())
+ [m_synchronizer setRate:m_rate];
if (!m_seeking)
m_player->timeChanged();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
