Title: [172385] trunk/Source/WebKit2
- Revision
- 172385
- Author
- [email protected]
- Date
- 2014-08-10 23:34:39 -0700 (Sun, 10 Aug 2014)
Log Message
[GTK] No IPC messages are sent when building WebKitGTK+ with VERSION_SCRIPT
https://bugs.webkit.org/show_bug.cgi?id=135760
Reviewed by Philippe Normand.
The problem is that the threading initialization is failing
because there are two copies of WTF, one in libjavascriptcoregtk
and the other in libwebkit2gtk. When WebKit2 is initialized in the
UI process, JSC::initializeThreading() is called first and then
WTF::initializeMainThread(). The former is calling
ThreadIdentifierData::initializeOnce() initializing the
ThreadIdentifierData::m_key symbol in libjavascriptcoregtk, while
the latter is using the ThreadIdentifierData API from libwebkit2gtk
that hasn't been initialized.
* CMakeLists.txt: Do not add WTF to the list of WebKit2 libraries,
WebKit2 already depends on _javascript_Core that already links to WTF.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/CMakeLists.txt (172384 => 172385)
--- trunk/Source/WebKit2/CMakeLists.txt 2014-08-11 04:22:11 UTC (rev 172384)
+++ trunk/Source/WebKit2/CMakeLists.txt 2014-08-11 06:34:39 UTC (rev 172385)
@@ -664,7 +664,6 @@
set(WebKit2_LIBRARIES
_javascript_Core
- WTF
WebCore
)
Modified: trunk/Source/WebKit2/ChangeLog (172384 => 172385)
--- trunk/Source/WebKit2/ChangeLog 2014-08-11 04:22:11 UTC (rev 172384)
+++ trunk/Source/WebKit2/ChangeLog 2014-08-11 06:34:39 UTC (rev 172385)
@@ -1,3 +1,23 @@
+2014-08-10 Carlos Garcia Campos <[email protected]>
+
+ [GTK] No IPC messages are sent when building WebKitGTK+ with VERSION_SCRIPT
+ https://bugs.webkit.org/show_bug.cgi?id=135760
+
+ Reviewed by Philippe Normand.
+
+ The problem is that the threading initialization is failing
+ because there are two copies of WTF, one in libjavascriptcoregtk
+ and the other in libwebkit2gtk. When WebKit2 is initialized in the
+ UI process, JSC::initializeThreading() is called first and then
+ WTF::initializeMainThread(). The former is calling
+ ThreadIdentifierData::initializeOnce() initializing the
+ ThreadIdentifierData::m_key symbol in libjavascriptcoregtk, while
+ the latter is using the ThreadIdentifierData API from libwebkit2gtk
+ that hasn't been initialized.
+
+ * CMakeLists.txt: Do not add WTF to the list of WebKit2 libraries,
+ WebKit2 already depends on _javascript_Core that already links to WTF.
+
2014-08-10 Tim Horton <[email protected]>
Yelp phone number highlights often disappear
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
