Title: [172510] trunk/Source/bmalloc
Revision
172510
Author
[email protected]
Date
2014-08-12 19:33:03 -0700 (Tue, 12 Aug 2014)

Log Message

BPLATFORM(IOS) always evaluates to false
https://bugs.webkit.org/show_bug.cgi?id=135843

Reviewed by Geoffrey Garen.

Fix typo in definition of BPLATFORM() and include system header TargetConditionals.h
(when building on an Apple platform) so that BPLATFORM(X) evaluates to true when
building for platform X. In particular, so that BPLATFORM(IOS) evaluates to true when
building for iOS.

As a side effect of this change, the change made in <http://trac.webkit.org/changeset/167289>
will be honored and iOS will assume a VM page size of 16kB (again) instead of 4kB.

* bmalloc/BPlatform.h:

Modified Paths

Diff

Modified: trunk/Source/bmalloc/ChangeLog (172509 => 172510)


--- trunk/Source/bmalloc/ChangeLog	2014-08-13 00:13:38 UTC (rev 172509)
+++ trunk/Source/bmalloc/ChangeLog	2014-08-13 02:33:03 UTC (rev 172510)
@@ -1,3 +1,20 @@
+2014-08-12  Daniel Bates  <[email protected]>
+
+        BPLATFORM(IOS) always evaluates to false
+        https://bugs.webkit.org/show_bug.cgi?id=135843
+
+        Reviewed by Geoffrey Garen.
+
+        Fix typo in definition of BPLATFORM() and include system header TargetConditionals.h
+        (when building on an Apple platform) so that BPLATFORM(X) evaluates to true when
+        building for platform X. In particular, so that BPLATFORM(IOS) evaluates to true when
+        building for iOS.
+
+        As a side effect of this change, the change made in <http://trac.webkit.org/changeset/167289>
+        will be honored and iOS will assume a VM page size of 16kB (again) instead of 4kB.
+
+        * bmalloc/BPlatform.h:
+
 2014-08-11  Andy Estes  <[email protected]>
 
         [iOS] Get rid of iOS.xcconfig

Modified: trunk/Source/bmalloc/bmalloc/BPlatform.h (172509 => 172510)


--- trunk/Source/bmalloc/bmalloc/BPlatform.h	2014-08-13 00:13:38 UTC (rev 172509)
+++ trunk/Source/bmalloc/bmalloc/BPlatform.h	2014-08-13 02:33:03 UTC (rev 172510)
@@ -26,8 +26,12 @@
 #ifndef BPlatform_h
 #define BPlatform_h
 
-#define BPLATFORM(PLATFORM) (defined BPLATFORM_##PLATFORM && PLATFORM_##PLATFORM)
+#ifdef __APPLE__
+#include <TargetConditionals.h>
+#endif
 
+#define BPLATFORM(PLATFORM) (defined BPLATFORM_##PLATFORM && BPLATFORM_##PLATFORM)
+
 #if ((defined(TARGET_OS_EMBEDDED) && TARGET_OS_EMBEDDED) \
     || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) \
     || (defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to