Title: [172620] trunk/Source/WebCore
- Revision
- 172620
- Author
- [email protected]
- Date
- 2014-08-14 21:10:26 -0700 (Thu, 14 Aug 2014)
Log Message
Preserve editing style for -webkit-tap-highlight-color on all ports that enable ENABLE_TOUCH_EVENTS
https://bugs.webkit.org/show_bug.cgi?id=135963
Reviewed by Andy Estes.
Currently we only preserve the CSS property -webkit-tap-highlight-color during editing operations
for iOS. Instead we should preserve it for all ports that enable ENABLE_TOUCH_EVENTS as this CSS
property isn't specific to iOS.
Also added FIXME comment with regards to the CSS property -webkit-composition-fill-color.
* editing/EditingStyle.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (172619 => 172620)
--- trunk/Source/WebCore/ChangeLog 2014-08-15 04:06:27 UTC (rev 172619)
+++ trunk/Source/WebCore/ChangeLog 2014-08-15 04:10:26 UTC (rev 172620)
@@ -1,3 +1,18 @@
+2014-08-14 Daniel Bates <[email protected]>
+
+ Preserve editing style for -webkit-tap-highlight-color on all ports that enable ENABLE_TOUCH_EVENTS
+ https://bugs.webkit.org/show_bug.cgi?id=135963
+
+ Reviewed by Andy Estes.
+
+ Currently we only preserve the CSS property -webkit-tap-highlight-color during editing operations
+ for iOS. Instead we should preserve it for all ports that enable ENABLE_TOUCH_EVENTS as this CSS
+ property isn't specific to iOS.
+
+ Also added FIXME comment with regards to the CSS property -webkit-composition-fill-color.
+
+ * editing/EditingStyle.cpp:
+
2014-08-14 Benjamin Poulain <[email protected]>
CSS JIT: compile the :empty pseudo class
Modified: trunk/Source/WebCore/editing/EditingStyle.cpp (172619 => 172620)
--- trunk/Source/WebCore/editing/EditingStyle.cpp 2014-08-15 04:06:27 UTC (rev 172619)
+++ trunk/Source/WebCore/editing/EditingStyle.cpp 2014-08-15 04:10:26 UTC (rev 172620)
@@ -71,8 +71,12 @@
CSSPropertyWhiteSpace,
CSSPropertyWidows,
CSSPropertyWordSpacing,
+#if ENABLE(TOUCH_EVENTS)
+ CSSPropertyWebkitTapHighlightColor,
+#endif
#if PLATFORM(IOS)
- CSSPropertyWebkitTapHighlightColor,
+ // FIXME: CSSPropertyWebkitCompositionFillColor shouldn't be iOS-specific. Once we fix up its usage in InlineTextBox::paintCompositionBackground()
+ // we should remove the PLATFORM(IOS)-guard. See <https://bugs.webkit.org/show_bug.cgi?id=126296>.
CSSPropertyWebkitCompositionFillColor,
#endif
CSSPropertyWebkitTextDecorationsInEffect,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
