Title: [172783] trunk/Source/_javascript_Core
- Revision
- 172783
- Author
- [email protected]
- Date
- 2014-08-19 16:38:51 -0700 (Tue, 19 Aug 2014)
Log Message
[Cocoa] Offline Assembler build phase fails when $BUILT_PRODUCTS_DIR contains spaces
https://bugs.webkit.org/show_bug.cgi?id=136086
Reviewed by Filip Pizlo.
Enclosed arguments to asm.rb containing $BUILT_PRODUCTS_DIR in double quotes so that they don't get split on
whitespace. Also let Xcode have its way with an unrelated part of the project file.
* _javascript_Core.xcodeproj/project.pbxproj:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (172782 => 172783)
--- trunk/Source/_javascript_Core/ChangeLog 2014-08-19 23:35:53 UTC (rev 172782)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-08-19 23:38:51 UTC (rev 172783)
@@ -1,3 +1,15 @@
+2014-08-19 Andy Estes <[email protected]>
+
+ [Cocoa] Offline Assembler build phase fails when $BUILT_PRODUCTS_DIR contains spaces
+ https://bugs.webkit.org/show_bug.cgi?id=136086
+
+ Reviewed by Filip Pizlo.
+
+ Enclosed arguments to asm.rb containing $BUILT_PRODUCTS_DIR in double quotes so that they don't get split on
+ whitespace. Also let Xcode have its way with an unrelated part of the project file.
+
+ * _javascript_Core.xcodeproj/project.pbxproj:
+
2014-08-19 Filip Pizlo <[email protected]>
LLInt build should be way faster
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (172782 => 172783)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2014-08-19 23:35:53 UTC (rev 172782)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2014-08-19 23:38:51 UTC (rev 172783)
@@ -6963,7 +6963,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "if [[ \"${ACTION}\" == \"installhdrs\" ]]; then\n exit 0\nfi\n\ncd \"${BUILT_PRODUCTS_DIR}/DerivedSources/_javascript_Core\"\n\n/usr/bin/env ruby _javascript_Core/offlineasm/asm.rb -I${BUILT_PRODUCTS_DIR}/DerivedSources/_javascript_Core _javascript_Core/llint/LowLevelInterpreter.asm ${BUILT_PRODUCTS_DIR}/JSCLLIntOffsetsExtractor LLIntAssembly.h || exit 1";
+ shellScript = "if [[ \"${ACTION}\" == \"installhdrs\" ]]; then\n exit 0\nfi\n\ncd \"${BUILT_PRODUCTS_DIR}/DerivedSources/_javascript_Core\"\n\n/usr/bin/env ruby _javascript_Core/offlineasm/asm.rb \"-I${BUILT_PRODUCTS_DIR}/DerivedSources/_javascript_Core\" _javascript_Core/llint/LowLevelInterpreter.asm \"${BUILT_PRODUCTS_DIR}/JSCLLIntOffsetsExtractor\" LLIntAssembly.h || exit 1";
};
65FB3F6509D11E9100F49DEB /* Generate Derived Sources */ = {
isa = PBXShellScriptBuildPhase;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
