Title: [172799] trunk/Source
- Revision
- 172799
- Author
- [email protected]
- Date
- 2014-08-20 10:59:10 -0700 (Wed, 20 Aug 2014)
Log Message
Enable ARM64 disassembler on EFL
https://bugs.webkit.org/show_bug.cgi?id=136089
Patch by Akos Kiss <[email protected]> on 2014-08-20
Reviewed by Filip Pizlo.
Source/_javascript_Core:
* CMakeLists.txt:
Added disassembler/ARM64Disassembler.cpp and
disassembler/ARM64/A64DOpcode.cpp to _javascript_Core_SOURCES.
* disassembler/ARM64/A64DOpcode.cpp:
Added USE(ARM64_DISASSEMBLER) guard around implementation.
* disassembler/ARM64/A64DOpcode.h:
(JSC::ARM64Disassembler::A64DOpcode::appendUnsignedImmediate64):
(JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset):
Made format strings portable by changing "%llx" to "%" PRIx64 for
uint64_t arguments.
Source/WTF:
* wtf/Platform.h:
Enable WTF_USE_ARM64_DISASSEMBLER for EFL as well.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/CMakeLists.txt (172798 => 172799)
--- trunk/Source/_javascript_Core/CMakeLists.txt 2014-08-20 17:56:27 UTC (rev 172798)
+++ trunk/Source/_javascript_Core/CMakeLists.txt 2014-08-20 17:59:10 UTC (rev 172799)
@@ -225,7 +225,9 @@
dfg/DFGWatchpointCollectionPhase.cpp
dfg/DFGWorklist.cpp
+ disassembler/ARM64/A64DOpcode.cpp
disassembler/ARMv7/ARMv7DOpcode.cpp
+ disassembler/ARM64Disassembler.cpp
disassembler/ARMv7Disassembler.cpp
disassembler/Disassembler.cpp
disassembler/LLVMDisassembler.cpp
Modified: trunk/Source/_javascript_Core/ChangeLog (172798 => 172799)
--- trunk/Source/_javascript_Core/ChangeLog 2014-08-20 17:56:27 UTC (rev 172798)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-08-20 17:59:10 UTC (rev 172799)
@@ -1,3 +1,23 @@
+2014-08-20 Akos Kiss <[email protected]>
+
+ Enable ARM64 disassembler on EFL
+ https://bugs.webkit.org/show_bug.cgi?id=136089
+
+ Reviewed by Filip Pizlo.
+
+ * CMakeLists.txt:
+ Added disassembler/ARM64Disassembler.cpp and
+ disassembler/ARM64/A64DOpcode.cpp to _javascript_Core_SOURCES.
+
+ * disassembler/ARM64/A64DOpcode.cpp:
+ Added USE(ARM64_DISASSEMBLER) guard around implementation.
+
+ * disassembler/ARM64/A64DOpcode.h:
+ (JSC::ARM64Disassembler::A64DOpcode::appendUnsignedImmediate64):
+ (JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset):
+ Made format strings portable by changing "%llx" to "%" PRIx64 for
+ uint64_t arguments.
+
2014-08-19 Filip Pizlo <[email protected]>
REGRESSION(r172401): for-in optimization no longer works at all
Modified: trunk/Source/_javascript_Core/disassembler/ARM64/A64DOpcode.cpp (172798 => 172799)
--- trunk/Source/_javascript_Core/disassembler/ARM64/A64DOpcode.cpp 2014-08-20 17:56:27 UTC (rev 172798)
+++ trunk/Source/_javascript_Core/disassembler/ARM64/A64DOpcode.cpp 2014-08-20 17:59:10 UTC (rev 172799)
@@ -24,6 +24,9 @@
*/
#include "config.h"
+
+#if USE(ARM64_DISASSEMBLER)
+
#include "A64DOpcode.h"
#include <stdarg.h>
@@ -1194,3 +1197,5 @@
}
} } // namespace JSC::ARM64Disassembler
+
+#endif // USE(ARM64_DISASSEMBLER)
Modified: trunk/Source/_javascript_Core/disassembler/ARM64/A64DOpcode.h (172798 => 172799)
--- trunk/Source/_javascript_Core/disassembler/ARM64/A64DOpcode.h 2014-08-20 17:56:27 UTC (rev 172798)
+++ trunk/Source/_javascript_Core/disassembler/ARM64/A64DOpcode.h 2014-08-20 17:59:10 UTC (rev 172799)
@@ -172,12 +172,12 @@
void appendUnsignedImmediate64(uint64_t immediate)
{
- bufferPrintf("#0x%llx", immediate);
+ bufferPrintf("#0x%" PRIx64, immediate);
}
void appendPCRelativeOffset(uint32_t* pc, int32_t immediate)
{
- bufferPrintf("0x%llx", reinterpret_cast<uint64_t>(pc + immediate));
+ bufferPrintf("0x%" PRIx64, reinterpret_cast<uint64_t>(pc + immediate));
}
void appendShiftAmount(unsigned amount)
Modified: trunk/Source/WTF/ChangeLog (172798 => 172799)
--- trunk/Source/WTF/ChangeLog 2014-08-20 17:56:27 UTC (rev 172798)
+++ trunk/Source/WTF/ChangeLog 2014-08-20 17:59:10 UTC (rev 172799)
@@ -1,3 +1,13 @@
+2014-08-20 Akos Kiss <[email protected]>
+
+ Enable ARM64 disassembler on EFL
+ https://bugs.webkit.org/show_bug.cgi?id=136089
+
+ Reviewed by Filip Pizlo.
+
+ * wtf/Platform.h:
+ Enable WTF_USE_ARM64_DISASSEMBLER for EFL as well.
+
2014-08-19 Pratik Solanki <[email protected]>
Remove PurgeableBuffer since it is not very useful any more
Modified: trunk/Source/WTF/wtf/Platform.h (172798 => 172799)
--- trunk/Source/WTF/wtf/Platform.h 2014-08-20 17:56:27 UTC (rev 172798)
+++ trunk/Source/WTF/wtf/Platform.h 2014-08-20 17:59:10 UTC (rev 172799)
@@ -676,7 +676,7 @@
#define ENABLE_DISASSEMBLER 1
#endif
-#if !defined(WTF_USE_ARM64_DISASSEMBLER) && ENABLE(JIT) && PLATFORM(IOS) && CPU(ARM64) && !USE(LLVM_DISASSEMBLER)
+#if !defined(WTF_USE_ARM64_DISASSEMBLER) && ENABLE(JIT) && (PLATFORM(IOS) || PLATFORM(EFL)) && CPU(ARM64) && !USE(LLVM_DISASSEMBLER)
#define WTF_USE_ARM64_DISASSEMBLER 1
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
