Title: [172801] trunk/Source/_javascript_Core
Revision
172801
Author
[email protected]
Date
2014-08-20 11:11:15 -0700 (Wed, 20 Aug 2014)

Log Message

[Win] Assertion fails when running JSC stress tests.
https://bugs.webkit.org/show_bug.cgi?id=136103

Patch by [email protected] <[email protected]> on 2014-08-20
Reviewed by Darin Adler.

Use unsigned bitfield member instead of enum bitfield member to avoid negative values.

* bytecode/CodeOrigin.h: Use unsigned bitfield member.
(JSC::InlineCallFrame::specializationKind): Compile fix.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (172800 => 172801)


--- trunk/Source/_javascript_Core/ChangeLog	2014-08-20 18:05:02 UTC (rev 172800)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-08-20 18:11:15 UTC (rev 172801)
@@ -1,3 +1,15 @@
+2014-08-20  [email protected]  <[email protected]>
+
+        [Win] Assertion fails when running JSC stress tests.
+        https://bugs.webkit.org/show_bug.cgi?id=136103
+
+        Reviewed by Darin Adler.
+
+        Use unsigned bitfield member instead of enum bitfield member to avoid negative values.
+
+        * bytecode/CodeOrigin.h: Use unsigned bitfield member.
+        (JSC::InlineCallFrame::specializationKind): Compile fix.
+
 2014-08-20  Akos Kiss  <[email protected]>
 
         Enable ARM64 disassembler on EFL

Modified: trunk/Source/_javascript_Core/bytecode/CodeOrigin.h (172800 => 172801)


--- trunk/Source/_javascript_Core/bytecode/CodeOrigin.h	2014-08-20 18:05:02 UTC (rev 172800)
+++ trunk/Source/_javascript_Core/bytecode/CodeOrigin.h	2014-08-20 18:11:15 UTC (rev 172801)
@@ -160,7 +160,7 @@
     CodeOrigin caller;
     BitVector capturedVars; // Indexed by the machine call frame's variable numbering.
     signed stackOffset : 30;
-    Kind kind : 2;
+    unsigned kind : 2; // real type is Kind
     bool isClosureCall : 1; // If false then we know that callee/scope are constants and the DFG won't treat them as variables, i.e. they have to be recovered manually.
     VirtualRegister argumentsRegister; // This is only set if the code uses arguments. The unmodified arguments register follows the unmodifiedArgumentsRegister() convention (see CodeBlock.h).
     
@@ -174,7 +174,7 @@
     {
     }
     
-    CodeSpecializationKind specializationKind() const { return specializationKindFor(kind); }
+    CodeSpecializationKind specializationKind() const { return specializationKindFor(static_cast<Kind>(kind)); }
 
     JSFunction* calleeConstant() const
     {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to