Diff
Modified: trunk/LayoutTests/ChangeLog (172816 => 172817)
--- trunk/LayoutTests/ChangeLog 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/LayoutTests/ChangeLog 2014-08-20 22:55:29 UTC (rev 172817)
@@ -1,3 +1,15 @@
+2014-08-20 Benjamin Poulain <[email protected]>
+
+ Remove HTMLInputElement's suggestedValue
+ https://bugs.webkit.org/show_bug.cgi?id=136094
+
+ Reviewed by Darin Adler.
+
+ * fast/forms/suggested-value-after-setvalue-expected.txt: Removed.
+ * fast/forms/suggested-value-after-setvalue.html: Removed.
+ * fast/forms/suggested-value-expected.txt: Removed.
+ * fast/forms/suggested-value.html: Removed.
+
2014-08-20 Dean Jackson <[email protected]>
WebAudio FFT analysis uses incorrect scaling
Deleted: trunk/LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt (172816 => 172817)
--- trunk/LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt 2014-08-20 22:55:29 UTC (rev 172817)
@@ -1,32 +0,0 @@
-This test setting a value clears suggested value.
-
-After setting suggestedValue:
-| <input>
-| id="test"
-| type="text"
-| value="initial value"
-| this.value="initial value"
-| <shadow:root>
-| <div>
-| contenteditable="plaintext-only"
-| "suggested value"
-| "input.value: initial value"
-| "internals.suggestedValue(input): suggested value"
-| "input.selectionStart: 0"
-| "input.selectionEnd: 0"
-
-After setting value:
-| <input>
-| id="test"
-| type="text"
-| value="initial value"
-| this.value="new value"
-| <shadow:root>
-| <div>
-| contenteditable="plaintext-only"
-| "new value"
-| "input.value: new value"
-| "internals.suggestedValue(input): "
-| "input.selectionStart: 9"
-| "input.selectionEnd: 9"
-| "PASS"
Deleted: trunk/LayoutTests/fast/forms/suggested-value-after-setvalue.html (172816 => 172817)
--- trunk/LayoutTests/fast/forms/suggested-value-after-setvalue.html 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/LayoutTests/fast/forms/suggested-value-after-setvalue.html 2014-08-20 22:55:29 UTC (rev 172817)
@@ -1,48 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<p id="description">This test setting a value clears suggested value.</p>
-<pre><input id="test" type="text" value="initial value"></pre>
-<script src=""
-<script>
-
-var input = document.getElementById('test');
-var result = document.getElementById('result');
-if (!window.internals)
- testFailed('This test requires internals object');
-else {
- input.focus();
- input.selectionStart = input.selectionEnd = 0;
-
- internals.setSuggestedValue(input, 'suggested value');
-
- Markup.description(document.getElementById('description').textContent)
-
- function addText(text) {
- input.parentNode.appendChild(document.createTextNode(text));
- }
-
- function log() {
- while (input.parentNode.firstChild != input.parentNode.lastChild)
- input.parentNode.removeChild(input.parentNode.lastChild);
- function addTextResult(value) { addText(value + ': ' + eval(value)); }
- addTextResult('input.value');
- addTextResult('internals.suggestedValue(input)');
- addTextResult('input.selectionStart');
- addTextResult('input.selectionEnd');
- }
-
- log();
- Markup.dump(input.parentNode, 'After setting suggestedValue');
-
- input.value = 'new value';
-
- log();
- var innerTextValue = internals.shadowRoot(input).firstChild.innerText;
- addText(innerTextValue == 'new value' ? 'PASS' : 'FAIL');
- Markup.dump(input.parentNode, 'After setting value');
-}
-
-</script>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/forms/suggested-value-expected.txt (172816 => 172817)
--- trunk/LayoutTests/fast/forms/suggested-value-expected.txt 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/LayoutTests/fast/forms/suggested-value-expected.txt 2014-08-20 22:55:29 UTC (rev 172817)
@@ -1,15 +0,0 @@
-This test setting a suggested value on an input element.
-The dump below should have the "suggested value" instead of "initial value".
-| <input>
-| id="test"
-| type="text"
-| value="initial value"
-| this.value="initial value"
-| <shadow:root>
-| <div>
-| contenteditable="plaintext-only"
-| "suggested value"
-| "input.value: initial value"
-| "internals.suggestedValue(input): suggested value"
-| "input.selectionStart: 0"
-| "input.selectionEnd: 0"
Deleted: trunk/LayoutTests/fast/forms/suggested-value.html (172816 => 172817)
--- trunk/LayoutTests/fast/forms/suggested-value.html 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/LayoutTests/fast/forms/suggested-value.html 2014-08-20 22:55:29 UTC (rev 172817)
@@ -1,33 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<p id="description">This test setting a suggested value on an input element.
-The dump below should have the "suggested value" instead of "initial value".</p>
-<pre><input id="test" type="text" value="initial value"></pre>
-<script src=""
-<script>
-
-var input = document.getElementById('test');
-var result = document.getElementById('result');
-if (!window.internals)
- testFailed('This test requires internals object');
-else {
- input.focus();
- input.selectionStart = input.selectionEnd = 0;
-
- internals.setSuggestedValue(input, 'suggested value');
-
- Markup.description(document.getElementById('description').textContent)
-
- function addTextResult(value) { input.parentNode.appendChild(document.createTextNode(value + ': ' + eval(value))); }
- addTextResult('input.value');
- addTextResult('internals.suggestedValue(input)');
- addTextResult('input.selectionStart');
- addTextResult('input.selectionEnd');
-
- Markup.dump(input.parentNode);
-}
-
-</script>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (172816 => 172817)
--- trunk/Source/WebCore/ChangeLog 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/ChangeLog 2014-08-20 22:55:29 UTC (rev 172817)
@@ -1,3 +1,36 @@
+2014-08-20 Benjamin Poulain <[email protected]>
+
+ Remove HTMLInputElement's suggestedValue
+ https://bugs.webkit.org/show_bug.cgi?id=136094
+
+ Reviewed by Darin Adler.
+
+ That code is Chrome specific. It is unused now.
+
+ * WebCore.exp.in:
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::setValue):
+ (WebCore::HTMLInputElement::setValueFromRenderer):
+ (WebCore::HTMLInputElement::suggestedValue): Deleted.
+ (WebCore::HTMLInputElement::setSuggestedValue): Deleted.
+ * html/HTMLInputElement.h:
+ * html/HTMLTextFormControlElement.cpp:
+ (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
+ * html/HTMLTextFormControlElement.h:
+ (WebCore::HTMLTextFormControlElement::isEmptySuggestedValue): Deleted.
+ * html/InputType.cpp:
+ (WebCore::InputType::canSetSuggestedValue): Deleted.
+ * html/InputType.h:
+ * html/TextFieldInputType.cpp:
+ (WebCore::TextFieldInputType::updateInnerTextValue):
+ (WebCore::TextFieldInputType::canSetSuggestedValue): Deleted.
+ * html/TextFieldInputType.h:
+ * testing/Internals.cpp:
+ (WebCore::Internals::suggestedValue): Deleted.
+ (WebCore::Internals::setSuggestedValue): Deleted.
+ * testing/Internals.h:
+ * testing/Internals.idl:
+
2014-08-20 Dean Jackson <[email protected]>
WebAudio FFT analysis uses incorrect scaling
Modified: trunk/Source/WebCore/WebCore.exp.in (172816 => 172817)
--- trunk/Source/WebCore/WebCore.exp.in 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/WebCore.exp.in 2014-08-20 22:55:29 UTC (rev 172817)
@@ -689,7 +689,6 @@
__ZN7WebCore16HTMLInputElement15setEditingValueERKN3WTF6StringE
__ZN7WebCore16HTMLInputElement15setValueForUserERKN3WTF6StringE
__ZN7WebCore16HTMLInputElement16setValueAsNumberEdRiNS_22TextFieldEventBehaviorE
-__ZN7WebCore16HTMLInputElement17setSuggestedValueERKN3WTF6StringE
__ZN7WebCore16HTMLInputElement8setValueERKN3WTF6StringENS_22TextFieldEventBehaviorE
__ZN7WebCore16IconDatabaseBase28synchronousIconURLForPageURLERKN3WTF6StringE
__ZN7WebCore16IconDatabaseBase4openERKN3WTF6StringES4_
@@ -1768,7 +1767,6 @@
__ZNK7WebCore16HTMLInputElement13isNumberFieldEv
__ZNK7WebCore16HTMLInputElement13isSearchFieldEv
__ZNK7WebCore16HTMLInputElement13valueAsNumberEv
-__ZNK7WebCore16HTMLInputElement14suggestedValueEv
__ZNK7WebCore16HTMLInputElement15isDateTimeFieldEv
__ZNK7WebCore16HTMLInputElement15isPasswordFieldEv
__ZNK7WebCore16HTMLInputElement16isTelephoneFieldEv
Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (172816 => 172817)
--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2014-08-20 22:55:29 UTC (rev 172817)
@@ -928,21 +928,6 @@
setValue(value, DispatchChangeEvent);
}
-const String& HTMLInputElement::suggestedValue() const
-{
- return m_suggestedValue;
-}
-
-void HTMLInputElement::setSuggestedValue(const String& value)
-{
- if (!m_inputType->canSetSuggestedValue())
- return;
- setFormControlValueMatchesRenderer(false);
- m_suggestedValue = sanitizeValue(value);
- setNeedsStyleRecalc();
- m_inputType->updateInnerTextValue();
-}
-
void HTMLInputElement::setEditingValue(const String& value)
{
if (!renderer() || !isTextField())
@@ -980,7 +965,6 @@
setLastChangeWasNotUserEdit();
setFormControlValueMatchesRenderer(false);
- m_suggestedValue = String(); // Prevent TextFieldInputType::setValue from using the suggested value.
m_inputType->setValue(sanitizedValue, valueChanged, eventBehavior);
if (!valueChanged)
@@ -1023,8 +1007,6 @@
// File upload controls will never use this.
ASSERT(!isFileUpload());
- m_suggestedValue = String();
-
// Renderer and our event handler are responsible for sanitizing values.
ASSERT(value == sanitizeValue(value) || sanitizeValue(value).isEmpty());
Modified: trunk/Source/WebCore/html/HTMLInputElement.h (172816 => 172817)
--- trunk/Source/WebCore/html/HTMLInputElement.h 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/html/HTMLInputElement.h 2014-08-20 22:55:29 UTC (rev 172817)
@@ -185,9 +185,6 @@
// The value which is drawn by a renderer.
String visibleValue() const;
- const String& suggestedValue() const;
- void setSuggestedValue(const String&);
-
void setEditingValue(const String&);
double valueAsDate() const;
@@ -396,7 +393,6 @@
virtual bool supportsPlaceholder() const override;
virtual void updatePlaceholderText() override;
virtual bool isEmptyValue() const override { return innerTextValue().isEmpty(); }
- virtual bool isEmptySuggestedValue() const override { return suggestedValue().isEmpty(); }
virtual void handleFocusEvent(Node* oldFocusedNode, FocusDirection) override;
virtual void handleBlurEvent() override;
@@ -422,7 +418,6 @@
AtomicString m_name;
String m_valueIfDirty;
- String m_suggestedValue;
int m_size;
int m_maxLength;
short m_maxResults;
Modified: trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp (172816 => 172817)
--- trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp 2014-08-20 22:55:29 UTC (rev 172817)
@@ -149,7 +149,6 @@
{
return supportsPlaceholder()
&& isEmptyValue()
- && isEmptySuggestedValue()
&& !isPlaceholderEmpty()
&& (document().focusedElement() != this || (renderer() && renderer()->theme().shouldShowPlaceholderWhenFocused()))
&& (!renderer() || renderer()->style().visibility() == VISIBLE);
Modified: trunk/Source/WebCore/html/HTMLTextFormControlElement.h (172816 => 172817)
--- trunk/Source/WebCore/html/HTMLTextFormControlElement.h 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/html/HTMLTextFormControlElement.h 2014-08-20 22:55:29 UTC (rev 172817)
@@ -132,8 +132,6 @@
// Returns true if user-editable value is empty. Used to check placeholder visibility.
virtual bool isEmptyValue() const = 0;
- // Returns true if suggested value is empty. Used to check placeholder visibility.
- virtual bool isEmptySuggestedValue() const { return true; }
// Called in dispatchFocusEvent(), after placeholder process, before calling parent's dispatchFocusEvent().
virtual void handleFocusEvent(Node* /* oldFocusedNode */, FocusDirection) { }
// Called in dispatchBlurEvent(), after placeholder process, before calling parent's dispatchBlurEvent().
Modified: trunk/Source/WebCore/html/InputType.cpp (172816 => 172817)
--- trunk/Source/WebCore/html/InputType.cpp 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/html/InputType.cpp 2014-08-20 22:55:29 UTC (rev 172817)
@@ -665,11 +665,6 @@
return String();
}
-bool InputType::canSetSuggestedValue()
-{
- return false;
-}
-
bool InputType::shouldSendChangeEventAfterCheckedChanged()
{
return true;
Modified: trunk/Source/WebCore/html/InputType.h (172816 => 172817)
--- trunk/Source/WebCore/html/InputType.h 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/html/InputType.h 2014-08-20 22:55:29 UTC (rev 172817)
@@ -252,8 +252,6 @@
virtual String displayString() const;
#endif
- // Should return true if the corresponding renderer for a type can display a suggested value.
- virtual bool canSetSuggestedValue();
virtual bool shouldSendChangeEventAfterCheckedChanged();
virtual bool canSetValue(const String&);
virtual bool storesValueSeparateFromAttribute();
Modified: trunk/Source/WebCore/html/TextFieldInputType.cpp (172816 => 172817)
--- trunk/Source/WebCore/html/TextFieldInputType.cpp 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/html/TextFieldInputType.cpp 2014-08-20 22:55:29 UTC (rev 172817)
@@ -92,11 +92,6 @@
return element().isRequired() && value.isEmpty();
}
-bool TextFieldInputType::canSetSuggestedValue()
-{
- return true;
-}
-
void TextFieldInputType::setValue(const String& sanitizedValue, bool valueChanged, TextFieldEventBehavior eventBehavior)
{
// Grab this input element to keep reference even if JS event handler
@@ -473,10 +468,7 @@
void TextFieldInputType::updateInnerTextValue()
{
- if (!element().suggestedValue().isNull()) {
- element().setInnerTextValue(element().suggestedValue());
- element().updatePlaceholderVisibility(false);
- } else if (!element().formControlValueMatchesRenderer()) {
+ if (!element().formControlValueMatchesRenderer()) {
// Update the renderer value if the formControlValueMatchesRenderer() flag is false.
// It protects an unacceptable renderer value from being overwritten with the DOM value.
element().setInnerTextValue(visibleValue());
Modified: trunk/Source/WebCore/html/TextFieldInputType.h (172816 => 172817)
--- trunk/Source/WebCore/html/TextFieldInputType.h 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/html/TextFieldInputType.h 2014-08-20 22:55:29 UTC (rev 172817)
@@ -45,7 +45,6 @@
protected:
explicit TextFieldInputType(HTMLInputElement&);
virtual ~TextFieldInputType();
- virtual bool canSetSuggestedValue() override;
virtual void handleKeydownEvent(KeyboardEvent*) override;
void handleKeydownEventForSpinButton(KeyboardEvent*);
Modified: trunk/Source/WebCore/testing/Internals.cpp (172816 => 172817)
--- trunk/Source/WebCore/testing/Internals.cpp 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/testing/Internals.cpp 2014-08-20 22:55:29 UTC (rev 172817)
@@ -924,38 +924,6 @@
return false;
}
-String Internals::suggestedValue(Element* element, ExceptionCode& ec)
-{
- if (!element) {
- ec = INVALID_ACCESS_ERR;
- return String();
- }
-
- HTMLInputElement* inputElement = element->toInputElement();
- if (!inputElement) {
- ec = INVALID_NODE_TYPE_ERR;
- return String();
- }
-
- return inputElement->suggestedValue();
-}
-
-void Internals::setSuggestedValue(Element* element, const String& value, ExceptionCode& ec)
-{
- if (!element) {
- ec = INVALID_ACCESS_ERR;
- return;
- }
-
- HTMLInputElement* inputElement = element->toInputElement();
- if (!inputElement) {
- ec = INVALID_NODE_TYPE_ERR;
- return;
- }
-
- inputElement->setSuggestedValue(value);
-}
-
void Internals::setEditingValue(Element* element, const String& value, ExceptionCode& ec)
{
if (!element) {
Modified: trunk/Source/WebCore/testing/Internals.h (172816 => 172817)
--- trunk/Source/WebCore/testing/Internals.h 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/testing/Internals.h 2014-08-20 22:55:29 UTC (rev 172817)
@@ -143,8 +143,6 @@
bool wasLastChangeUserEdit(Element* textField, ExceptionCode&);
bool elementShouldAutoComplete(Element* inputElement, ExceptionCode&);
- String suggestedValue(Element* inputElement, ExceptionCode&);
- void setSuggestedValue(Element* inputElement, const String&, ExceptionCode&);
void setEditingValue(Element* inputElement, const String&, ExceptionCode&);
void setAutofilled(Element*, bool enabled, ExceptionCode&);
void scrollElementToRect(Element*, long x, long y, long w, long h, ExceptionCode&);
Modified: trunk/Source/WebCore/testing/Internals.idl (172816 => 172817)
--- trunk/Source/WebCore/testing/Internals.idl 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebCore/testing/Internals.idl 2014-08-20 22:55:29 UTC (rev 172817)
@@ -98,8 +98,6 @@
[RaisesException] boolean wasLastChangeUserEdit(Element textField);
[RaisesException] boolean elementShouldAutoComplete(Element inputElement);
- [RaisesException] DOMString suggestedValue(Element inputElement);
- [RaisesException] void setSuggestedValue(Element inputElement, DOMString value);
[RaisesException] void setEditingValue(Element inputElement, DOMString value);
[RaisesException] void setAutofilled(Element inputElement, boolean enabled);
[RaisesException] unsigned long countMatchesForText(DOMString text, unsigned long findOptions, DOMString markMatches);
Modified: trunk/Source/WebKit/ChangeLog (172816 => 172817)
--- trunk/Source/WebKit/ChangeLog 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebKit/ChangeLog 2014-08-20 22:55:29 UTC (rev 172817)
@@ -1,3 +1,12 @@
+2014-08-20 Benjamin Poulain <[email protected]>
+
+ Remove HTMLInputElement's suggestedValue
+ https://bugs.webkit.org/show_bug.cgi?id=136094
+
+ Reviewed by Darin Adler.
+
+ * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
+
2014-08-20 Mark Rowe <[email protected]>
<https://webkit.org/b/136119> WebKit1 plug-in test failures in production builds after r172595
Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in (172816 => 172817)
--- trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in 2014-08-20 22:39:44 UTC (rev 172816)
+++ trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in 2014-08-20 22:55:29 UTC (rev 172817)
@@ -301,14 +301,12 @@
symbolWithPointer(?setSerifFontFamily@Settings@WebCore@@QAEXABVAtomicString@WTF@@W4UScriptCode@@@Z, ?setSerifFontFamily@Settings@WebCore@@QEAAXAEBVAtomicString@WTF@@W4UScriptCode@@@Z)
symbolWithPointer(?setStandardFontFamily@Settings@WebCore@@QAEXABVAtomicString@WTF@@W4UScriptCode@@@Z, ?setStandardFontFamily@Settings@WebCore@@QEAAXAEBVAtomicString@WTF@@W4UScriptCode@@@Z)
symbolWithPointer(?setStorageBlockingPolicy@Settings@WebCore@@QAEXW4StorageBlockingPolicy@SecurityOrigin@2@@Z, ?setStorageBlockingPolicy@Settings@WebCore@@QEAAXW4StorageBlockingPolicy@SecurityOrigin@2@@Z)
- symbolWithPointer(?setSuggestedValue@HTMLInputElement@WebCore@@QAEXABVString@WTF@@@Z, ?setSuggestedValue@HTMLInputElement@WebCore@@QEAAXAEBVString@WTF@@@Z)
symbolWithPointer(?setEditingValue@HTMLInputElement@WebCore@@QAEXABVString@WTF@@@Z, ?setEditingValue@HTMLInputElement@WebCore@@QEAAXAEBVString@WTF@@@Z)
symbolWithPointer(?setPseudo@Element@WebCore@@QAEXABVAtomicString@WTF@@@Z, ?setPseudo@Element@WebCore@@QEAAXAEBVAtomicString@WTF@@@Z)
symbolWithPointer(?setMediaTypeOverride@Settings@WebCore@@QAEXABVString@WTF@@@Z, ?setMediaTypeOverride@Settings@WebCore@@QEAAXAEBVString@WTF@@@Z)
symbolWithPointer(?settings@Document@WebCore@@QBEPAVSettings@2@XZ, ?settings@Document@WebCore@@QEBAPEAVSettings@2@XZ)
symbolWithPointer(?sharedFeatures@RuntimeEnabledFeatures@WebCore@@SAAAV12@XZ, ?sharedFeatures@RuntimeEnabledFeatures@WebCore@@SAAEAV12@XZ)
symbolWithPointer(?substring@String@WTF@@QBE?AV12@II@Z, ?substring@String@WTF@@QEBA?AV12@II@Z)
- symbolWithPointer(?suggestedValue@HTMLInputElement@WebCore@@QBEABVString@WTF@@XZ, ?suggestedValue@HTMLInputElement@WebCore@@QEBAAEBVString@WTF@@XZ)
symbolWithPointer(?target@HistoryItem@WebCore@@QBEABVString@WTF@@XZ, ?target@HistoryItem@WebCore@@QEBAAEBVString@WTF@@XZ)
symbolWithPointer(?text@Range@WebCore@@QBE?AVString@WTF@@XZ, ?text@Range@WebCore@@QEBA?AVString@WTF@@XZ)
?textareaTag@HTMLNames@WebCore@@3VHTMLQualifiedName@2@B
