Title: [172822] trunk/Source/_javascript_Core
- Revision
- 172822
- Author
- [email protected]
- Date
- 2014-08-20 19:29:47 -0700 (Wed, 20 Aug 2014)
Log Message
Fix how CodeBlock dumps the opcode op_profile_type
https://bugs.webkit.org/show_bug.cgi?id=136088
Patch by Saam Barati <[email protected]> on 2014-08-20
Reviewed by Filip Pizlo.
op_profile_type was modified to receive two extra arguments,
but its dump in CodeBlock::dumpBytecode wasn't changed to
account for this, so it broke CodeBlock::dumpBytecode when
op_profile_type was in the stream of bytecode instructions.
CodeBlock::dumpBytecode now accounts for the change in
op_profile_type's arity.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (172821 => 172822)
--- trunk/Source/_javascript_Core/ChangeLog 2014-08-21 01:18:47 UTC (rev 172821)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-08-21 02:29:47 UTC (rev 172822)
@@ -1,5 +1,22 @@
2014-08-20 Saam Barati <[email protected]>
+ Fix how CodeBlock dumps the opcode op_profile_type
+ https://bugs.webkit.org/show_bug.cgi?id=136088
+
+ Reviewed by Filip Pizlo.
+
+ op_profile_type was modified to receive two extra arguments,
+ but its dump in CodeBlock::dumpBytecode wasn't changed to
+ account for this, so it broke CodeBlock::dumpBytecode when
+ op_profile_type was in the stream of bytecode instructions.
+ CodeBlock::dumpBytecode now accounts for the change in
+ op_profile_type's arity.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dumpBytecode):
+
+2014-08-20 Saam Barati <[email protected]>
+
Rename HighFidelityTypeProfiling variables for more clarity
https://bugs.webkit.org/show_bug.cgi?id=135899
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (172821 => 172822)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2014-08-21 01:18:47 UTC (rev 172821)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2014-08-21 02:29:47 UTC (rev 172822)
@@ -843,6 +843,8 @@
int r0 = (++it)->u.operand;
++it;
++it;
+ ++it;
+ ++it;
printLocationAndOp(out, exec, location, it, "op_profile_type");
out.printf("%s", registerName(r0).data());
break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
