Title: [172979] trunk/Source
Revision
172979
Author
[email protected]
Date
2014-08-26 15:36:19 -0700 (Tue, 26 Aug 2014)

Log Message

[Cocoa] Some projects are incorrectly installed to $BUILT_PRODUCTS_DIR
https://bugs.webkit.org/show_bug.cgi?id=136267

Reviewed by Dan Bernstein.

INSTALL_PATH was set to $BUILT_PRODUCTS_DIR for engineering configurations in r20225 as part of a build fix.
Not only is this no longer necessary to build, but it causes built products to be incorrectly installed in
engineering configurations.

Remove the setting of INSTALL_PATH from the pbxproj file so that the value specified in the xcconfig files is
used instead.

Source/_javascript_Core:

* _javascript_Core.xcodeproj/project.pbxproj:

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit2:

* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (172978 => 172979)


--- trunk/Source/_javascript_Core/ChangeLog	2014-08-26 22:08:42 UTC (rev 172978)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-08-26 22:36:19 UTC (rev 172979)
@@ -1,3 +1,19 @@
+2014-08-26  Andy Estes  <[email protected]>
+
+        [Cocoa] Some projects are incorrectly installed to $BUILT_PRODUCTS_DIR
+        https://bugs.webkit.org/show_bug.cgi?id=136267
+
+        Reviewed by Dan Bernstein.
+
+        INSTALL_PATH was set to $BUILT_PRODUCTS_DIR for engineering configurations in r20225 as part of a build fix.
+        Not only is this no longer necessary to build, but it causes built products to be incorrectly installed in
+        engineering configurations.
+
+        Remove the setting of INSTALL_PATH from the pbxproj file so that the value specified in the xcconfig files is
+        used instead.
+
+        * _javascript_Core.xcodeproj/project.pbxproj:
+
 2014-08-26  Michael Saboff  <[email protected]>
 
         [Win] 64-bit _javascript_Core crashes on launch

Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (172978 => 172979)


--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2014-08-26 22:08:42 UTC (rev 172978)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2014-08-26 22:36:19 UTC (rev 172979)
@@ -7896,7 +7896,6 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1C9051430BA9E8A70081E9D0 /* _javascript_Core.xcconfig */;
 			buildSettings = {
-				INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
 			};
 			name = Debug;
 		};
@@ -7904,7 +7903,6 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1C9051430BA9E8A70081E9D0 /* _javascript_Core.xcconfig */;
 			buildSettings = {
-				INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
 			};
 			name = Release;
 		};
@@ -8184,7 +8182,6 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1C9051430BA9E8A70081E9D0 /* _javascript_Core.xcconfig */;
 			buildSettings = {
-				INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
 			};
 			name = Profiling;
 		};

Modified: trunk/Source/WebCore/ChangeLog (172978 => 172979)


--- trunk/Source/WebCore/ChangeLog	2014-08-26 22:08:42 UTC (rev 172978)
+++ trunk/Source/WebCore/ChangeLog	2014-08-26 22:36:19 UTC (rev 172979)
@@ -1,3 +1,19 @@
+2014-08-26  Andy Estes  <[email protected]>
+
+        [Cocoa] Some projects are incorrectly installed to $BUILT_PRODUCTS_DIR
+        https://bugs.webkit.org/show_bug.cgi?id=136267
+
+        Reviewed by Dan Bernstein.
+
+        INSTALL_PATH was set to $BUILT_PRODUCTS_DIR for engineering configurations in r20225 as part of a build fix.
+        Not only is this no longer necessary to build, but it causes built products to be incorrectly installed in
+        engineering configurations.
+
+        Remove the setting of INSTALL_PATH from the pbxproj file so that the value specified in the xcconfig files is
+        used instead.
+
+        * WebCore.xcodeproj/project.pbxproj:
+
 2014-08-26  Brent Fulgham  <[email protected]>
 
         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE

Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (172978 => 172979)


--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2014-08-26 22:08:42 UTC (rev 172978)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2014-08-26 22:36:19 UTC (rev 172979)
@@ -30009,7 +30009,6 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1CDD45E50BA9C84600F90147 /* WebCore.xcconfig */;
 			buildSettings = {
-				INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
 			};
 			name = Debug;
 		};
@@ -30017,7 +30016,6 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1CDD45E50BA9C84600F90147 /* WebCore.xcconfig */;
 			buildSettings = {
-				INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
 			};
 			name = Release;
 		};

Modified: trunk/Source/WebKit/ChangeLog (172978 => 172979)


--- trunk/Source/WebKit/ChangeLog	2014-08-26 22:08:42 UTC (rev 172978)
+++ trunk/Source/WebKit/ChangeLog	2014-08-26 22:36:19 UTC (rev 172979)
@@ -1,3 +1,19 @@
+2014-08-26  Andy Estes  <[email protected]>
+
+        [Cocoa] Some projects are incorrectly installed to $BUILT_PRODUCTS_DIR
+        https://bugs.webkit.org/show_bug.cgi?id=136267
+
+        Reviewed by Dan Bernstein.
+
+        INSTALL_PATH was set to $BUILT_PRODUCTS_DIR for engineering configurations in r20225 as part of a build fix.
+        Not only is this no longer necessary to build, but it causes built products to be incorrectly installed in
+        engineering configurations.
+
+        Remove the setting of INSTALL_PATH from the pbxproj file so that the value specified in the xcconfig files is
+        used instead.
+
+        * WebKit.xcodeproj/project.pbxproj:
+
 2014-08-20  Benjamin Poulain  <[email protected]>
 
         Remove HTMLInputElement's suggestedValue

Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (172978 => 172979)


--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2014-08-26 22:08:42 UTC (rev 172978)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2014-08-26 22:36:19 UTC (rev 172979)
@@ -2328,7 +2328,6 @@
 			baseConfigurationReference = 1C904FD20BA9DD0F0081E9D0 /* WebKitLegacy.xcconfig */;
 			buildSettings = {
 				DEBUG_DEFINES = "$(DEBUG_DEFINES_debug) ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH";
-				INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
 				OTHER_LDFLAGS = (
 					"$(OTHER_LDFLAGS)",
 					"-l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY)",
@@ -2341,7 +2340,6 @@
 			baseConfigurationReference = 1C904FD20BA9DD0F0081E9D0 /* WebKitLegacy.xcconfig */;
 			buildSettings = {
 				DEBUG_DEFINES = "$(DEBUG_DEFINES_$(CURRENT_VARIANT)) ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH";
-				INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
 				OTHER_LDFLAGS = (
 					"$(OTHER_LDFLAGS)",
 					"-l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY)",

Modified: trunk/Source/WebKit2/ChangeLog (172978 => 172979)


--- trunk/Source/WebKit2/ChangeLog	2014-08-26 22:08:42 UTC (rev 172978)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-26 22:36:19 UTC (rev 172979)
@@ -1,3 +1,19 @@
+2014-08-26  Andy Estes  <[email protected]>
+
+        [Cocoa] Some projects are incorrectly installed to $BUILT_PRODUCTS_DIR
+        https://bugs.webkit.org/show_bug.cgi?id=136267
+
+        Reviewed by Dan Bernstein.
+
+        INSTALL_PATH was set to $BUILT_PRODUCTS_DIR for engineering configurations in r20225 as part of a build fix.
+        Not only is this no longer necessary to build, but it causes built products to be incorrectly installed in
+        engineering configurations.
+
+        Remove the setting of INSTALL_PATH from the pbxproj file so that the value specified in the xcconfig files is
+        used instead.
+
+        * WebKit2.xcodeproj/project.pbxproj:
+
 2014-08-25  Maciej Stachowiak  <[email protected]>
 
         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API

Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (172978 => 172979)


--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2014-08-26 22:08:42 UTC (rev 172978)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2014-08-26 22:36:19 UTC (rev 172979)
@@ -9813,7 +9813,6 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = BCB86F4B116AAACD00CE20B7 /* WebKit.xcconfig */;
 			buildSettings = {
-				INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
 				OTHER_LDFLAGS = (
 					"$(OTHER_LDFLAGS)",
 					"-l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY)",
@@ -9825,7 +9824,6 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = BCB86F4B116AAACD00CE20B7 /* WebKit.xcconfig */;
 			buildSettings = {
-				INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
 				OTHER_LDFLAGS = (
 					"$(OTHER_LDFLAGS)",
 					"-l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY)",
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to