Title: [173169] trunk/LayoutTests
- Revision
- 173169
- Author
- [email protected]
- Date
- 2014-09-02 01:36:14 -0700 (Tue, 02 Sep 2014)
Log Message
[CSS Grid Layout] Test coverage for first-line pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=135770
Reviewed by Zoltan Horvath.
According to the spec the ::first-line pseudo-element do not apply to
grid containers.
This was already working as expected but we were missing some tests
checking it, so we are adding new tests to have coverage.
* fast/css-grid-layout/grid-container-ignore-first-line-expected.txt: Added.
* fast/css-grid-layout/grid-container-ignore-first-line.html: Added.
* fast/css-grid-layout/grid-item-first-line-valid-expected.txt: Added.
* fast/css-grid-layout/grid-item-first-line-valid.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (173168 => 173169)
--- trunk/LayoutTests/ChangeLog 2014-09-02 08:06:17 UTC (rev 173168)
+++ trunk/LayoutTests/ChangeLog 2014-09-02 08:36:14 UTC (rev 173169)
@@ -1,3 +1,21 @@
+2014-09-02 Manuel Rego Casasnovas <[email protected]>
+
+ [CSS Grid Layout] Test coverage for first-line pseudo-element
+ https://bugs.webkit.org/show_bug.cgi?id=135770
+
+ Reviewed by Zoltan Horvath.
+
+ According to the spec the ::first-line pseudo-element do not apply to
+ grid containers.
+
+ This was already working as expected but we were missing some tests
+ checking it, so we are adding new tests to have coverage.
+
+ * fast/css-grid-layout/grid-container-ignore-first-line-expected.txt: Added.
+ * fast/css-grid-layout/grid-container-ignore-first-line.html: Added.
+ * fast/css-grid-layout/grid-item-first-line-valid-expected.txt: Added.
+ * fast/css-grid-layout/grid-item-first-line-valid.html: Added.
+
2014-08-29 Sergio Villar Senin <[email protected]>
[CSS Grid Layout] Resolved value of grid-template-* must include every track listed
Added: trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line-expected.txt (0 => 173169)
--- trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line-expected.txt 2014-09-02 08:36:14 UTC (rev 173169)
@@ -0,0 +1,22 @@
+This test grid item should ignore grid container's first-line pseudo-element.
+
+The first item.
+The second item.
+PASS
+The first item.
+The second item.
+PASS
+Anonymous item.
+PASS
+Anonymous item.
+PASS
+The first item.
+The second item.
+PASS
+The first item.
+The second item.
+ PASS
+Anonymous item.
+PASS
+Anonymous item.
+PASS
Added: trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line.html (0 => 173169)
--- trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line.html 2014-09-02 08:36:14 UTC (rev 173169)
@@ -0,0 +1,59 @@
+<!DOCTYPE html>
+<html>
+<link href="" rel="stylesheet">
+<style>
+ body { line-height: 20px; }
+ .grid-first-line::first-line { line-height: 100px; }
+ .container::first-line { line-height: 200px; }
+</style>
+
+<script src=""
+<body _onload_="checkLayout('.grid-first-line');">
+<p>This test grid item should ignore grid container's first-line pseudo-element.</p>
+
+<div class="grid grid-first-line">
+ <div class="item" data-expected-height=20>The first item.</div>
+ <div class="item" data-expected-height=20>The second item.</div>
+</div>
+
+<div class="inline-grid grid-first-line">
+ <div class="item" data-expected-height=20>The first item.</div>
+ <div class="item" data-expected-height=20>The second item.</div>
+</div>
+
+<div class="grid grid-first-line" data-expected-height=20>
+ Anonymous item.
+</div>
+
+<div class="inline-grid grid-first-line" data-expected-height=20>
+ Anonymous item.
+</div>
+
+<div class="container">
+ <div class="grid grid-first-line">
+ <div class="item" data-expected-height=20>The first item.</div>
+ <div class="item" data-expected-height=20>The second item.</div>
+ </div>
+</div>
+
+<div class="container">
+ <div class="inline-grid grid-first-line">
+ <div class="item" data-expected-height=20>The first item.</div>
+ <div class="item" data-expected-height=20>The second item.</div>
+ </div>
+</div>
+
+<div class="container">
+ <div class="grid grid-first-line" data-expected-height=20>
+ Anonymous item.
+ </div>
+</div>
+
+<div class="container">
+ <div class="inline-grid grid-first-line" data-expected-height=20>
+ Anonymous item.
+ </div>
+</div>
+
+</body>
+</html>
Added: trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid-expected.txt (0 => 173169)
--- trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid-expected.txt 2014-09-02 08:36:14 UTC (rev 173169)
@@ -0,0 +1,8 @@
+This test grid item's first-line pseudo-element should be valid.
+
+The first item.
+The second item.
+PASS
+The first item.
+The second item.
+PASS
Added: trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid.html (0 => 173169)
--- trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid.html 2014-09-02 08:36:14 UTC (rev 173169)
@@ -0,0 +1,23 @@
+<!DOCTYPE html>
+<html>
+<link href="" rel="stylesheet">
+<style>
+ .item::first-line { line-height: 100px; }
+</style>
+
+<script src=""
+<body _onload_="checkLayout('.grid'); checkLayout('.inline-grid');">
+<p>This test grid item's first-line pseudo-element should be valid.</p>
+
+<div class="grid">
+ <div class="item" data-expected-height=100>The first item.</div>
+ <div class="item" data-expected-height=100>The second item.</div>
+</div>
+
+<div class="inline-grid">
+ <div class="item" data-expected-height=100>The first item.</div>
+ <div class="item" data-expected-height=100>The second item.</div>
+</div>
+
+</body>
+</html>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
