Modified: trunk/LayoutTests/ChangeLog (173330 => 173331)
--- trunk/LayoutTests/ChangeLog 2014-09-05 20:05:32 UTC (rev 173330)
+++ trunk/LayoutTests/ChangeLog 2014-09-05 20:25:01 UTC (rev 173331)
@@ -1,3 +1,12 @@
+2014-09-05 Carlos Alberto Lopez Perez <[email protected]>
+
+ [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
+ https://bugs.webkit.org/show_bug.cgi?id=136562
+
+ Reviewed by Martin Robinson.
+
+ * platform/gtk/TestExpectations: Remove failure expectations for tests that now pass.
+
2014-09-04 Michael Saboff <[email protected]>
ARM32 iOS: JSC Test math.js fails
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (173330 => 173331)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-09-05 20:05:32 UTC (rev 173330)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-09-05 20:25:01 UTC (rev 173331)
@@ -2115,9 +2115,6 @@
webkit.org/b/136537 css3/flexbox/flex-rounding.html [ Failure ]
webkit.org/b/136537 fast/sub-pixel/client-width-height-snapping.html [ Failure ]
-webkit.org/b/136562 http/tests/download/basic-ascii.html [ Failure ]
-webkit.org/b/136562 http/tests/download/literal-utf-8.html [ Failure ]
-
#////////////////////////////////////////////////////////////////////////////////////////
# End of Tests failing
#////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/Source/WebCore/ChangeLog (173330 => 173331)
--- trunk/Source/WebCore/ChangeLog 2014-09-05 20:05:32 UTC (rev 173330)
+++ trunk/Source/WebCore/ChangeLog 2014-09-05 20:25:01 UTC (rev 173331)
@@ -1,3 +1,16 @@
+2014-09-05 Carlos Alberto Lopez Perez <[email protected]>
+
+ [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
+ https://bugs.webkit.org/show_bug.cgi?id=136562
+
+ Reviewed by Martin Robinson.
+
+ No new tests, this makes existing tests pass.
+
+ * platform/network/soup/ResourceResponseSoup.cpp:
+ (WebCore::ResourceResponse::platformSuggestedFilename):
+ Implement ResourceResponse::platformSuggestedFilename() for SOUP after r173272, r173301 and r173305.
+
2014-09-05 [email protected] <[email protected]>
[Curl] Compile error.
Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (173330 => 173331)
--- trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2014-09-05 20:05:32 UTC (rev 173330)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2014-09-05 20:25:01 UTC (rev 173331)
@@ -103,7 +103,7 @@
String ResourceResponse::platformSuggestedFilename() const
{
- return String();
+ return filenameFromHTTPContentDisposition(httpHeaderField(HTTPHeaderName::ContentDisposition));
}
}
Modified: trunk/Tools/ChangeLog (173330 => 173331)
--- trunk/Tools/ChangeLog 2014-09-05 20:05:32 UTC (rev 173330)
+++ trunk/Tools/ChangeLog 2014-09-05 20:25:01 UTC (rev 173331)
@@ -1,3 +1,13 @@
+2014-09-05 Carlos Alberto Lopez Perez <[email protected]>
+
+ [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
+ https://bugs.webkit.org/show_bug.cgi?id=136562
+
+ Reviewed by Martin Robinson.
+
+ * Scripts/run-gtk-tests:
+ (TestRunner): Remove failure expectations for tests that now pass.
+
2014-09-04 Alexey Proskuryakov <[email protected]>
Dashboard metrics page wastes a lot of time sorting iterations
Modified: trunk/Tools/Scripts/run-gtk-tests (173330 => 173331)
--- trunk/Tools/Scripts/run-gtk-tests 2014-09-05 20:05:32 UTC (rev 173330)
+++ trunk/Tools/Scripts/run-gtk-tests 2014-09-05 20:25:01 UTC (rev 173331)
@@ -67,8 +67,6 @@
SkippedTest("WebKit2Gtk/TestWebKitWebView", "/webkit2/WebKitWebView/snapshot", "Test fails", 120404),
SkippedTest("WebKit2Gtk/TestWebKitWebView", "/webkit2/WebKitWebView/page-visibility", "Test fails or times out", 131731),
SkippedTest("WebKit2Gtk/TestCookieManager", "/webkit2/WebKitCookieManager/persistent-storage", "Test is flaky", 134580),
- SkippedTest("WebKit2Gtk/TestDownloads", "/webkit2/Downloads/remote-file", "Test fails since r173272", 136562),
- SkippedTest("WebKit2Gtk/TestResources", "/webkit2/WebKitWebResource/suggested-filename", "Test fails since r173272", 136562),
SkippedTest("WebKit2/TestWebKit2", "WebKit2.MouseMoveAfterCrash", "Test is flaky", 85066),
SkippedTest("WebKit2/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutForImages", "Test is flaky", 85066),
SkippedTest("WebKit2/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutFrames", "Test fails", 85037),
