Title: [173335] trunk
Revision
173335
Author
[email protected]
Date
2014-09-05 15:09:41 -0700 (Fri, 05 Sep 2014)

Log Message

Remove statically used varyings from packing restrictions check.
https://bugs.webkit.org/show_bug.cgi?id=136585.
<rdar://problem/16308409>

Reviewed by Dean Jackson.

* src/compiler/translator/Compiler.cpp:
(TCompiler::enforcePackingRestrictions):
* platform/mac/TestExpectations: Unskip build_009_to_016.html conformance test.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (173334 => 173335)


--- trunk/LayoutTests/ChangeLog	2014-09-05 21:32:00 UTC (rev 173334)
+++ trunk/LayoutTests/ChangeLog	2014-09-05 22:09:41 UTC (rev 173335)
@@ -1,3 +1,13 @@
+2014-09-05  Roger Fong  <[email protected]>
+
+        Remove statically used varyings from packing restrictions check.
+        https://bugs.webkit.org/show_bug.cgi?id=136585.
+        <rdar://problem/16308409>
+
+        Reviewed by Dean Jackson.
+
+        * platform/mac/TestExpectations: Unskip build_009_to_016.html conformance test.
+
 2014-09-05  Matt Baker  <[email protected]>
 
         Web Inspector: breakpoint actions should work regardless of Content Security Policy

Modified: trunk/LayoutTests/platform/mac/TestExpectations (173334 => 173335)


--- trunk/LayoutTests/platform/mac/TestExpectations	2014-09-05 21:32:00 UTC (rev 173334)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-09-05 22:09:41 UTC (rev 173335)
@@ -642,9 +642,6 @@
 webgl/1.0.2/conformance/textures/texture-size.html [ Pass Failure ]
 webgl/1.0.2/conformance/limits/gl-max-texture-dimensions.html [ Pass Failure ]
 
-# Test is faulty, skipping for now
-webgl/1.0.2/conformance/ogles/GL/build/build_009_to_016.html [ Failure ]
-
 # Skipping all webgl conformance tests on trunk
 webgl/conformance
 

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (173334 => 173335)


--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2014-09-05 21:32:00 UTC (rev 173334)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2014-09-05 22:09:41 UTC (rev 173335)
@@ -1,3 +1,14 @@
+2014-09-05  Roger Fong  <[email protected]>
+
+        Remove statically used varyings from packing restrictions check.
+        https://bugs.webkit.org/show_bug.cgi?id=136585.
+        <rdar://problem/16308409>
+
+        Reviewed by Dean Jackson.
+
+        * src/compiler/translator/Compiler.cpp:
+        (TCompiler::enforcePackingRestrictions):
+
 2014-08-29  Csaba Osztrogonác  <[email protected]>
 
         Unreviwed, remove empty directories.

Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp (173334 => 173335)


--- trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp	2014-09-05 21:32:00 UTC (rev 173334)
+++ trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp	2014-09-05 22:09:41 UTC (rev 173335)
@@ -460,8 +460,14 @@
         return false;
     }
 
-    success = packer.CheckVariablesWithinPackingLimits(maxVaryingVectors, varyings);
+    TVariableInfoList nonStaticallyUsedVaryings;
 
+    for (TVariableInfo info : varyings) {
+        if (!info.staticUse)
+            nonStaticallyUsedVaryings.push_back(info);
+    }
+    success = packer.CheckVariablesWithinPackingLimits(maxVaryingVectors, nonStaticallyUsedVaryings);
+
     if (!success) {
         infoSink.info.prefix(EPrefixError);
         infoSink.info << "too many varyings";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to