Title: [173389] trunk/Source/WebCore
- Revision
- 173389
- Author
- [email protected]
- Date
- 2014-09-08 11:32:12 -0700 (Mon, 08 Sep 2014)
Log Message
Remove some unused code in ImageSourceCG
https://bugs.webkit.org/show_bug.cgi?id=136638
Reviewed by Dan Bernstein.
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::setData):
Remove this code. Firstly, it's in a USE(CG) && !PLATFORM(COCOA) && !PLATFORM(WIN)
block, and that's simply not a thing. Secondly, the referenced bug was fixed in Lion.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (173388 => 173389)
--- trunk/Source/WebCore/ChangeLog 2014-09-08 18:14:24 UTC (rev 173388)
+++ trunk/Source/WebCore/ChangeLog 2014-09-08 18:32:12 UTC (rev 173389)
@@ -1,3 +1,15 @@
+2014-09-08 Tim Horton <[email protected]>
+
+ Remove some unused code in ImageSourceCG
+ https://bugs.webkit.org/show_bug.cgi?id=136638
+
+ Reviewed by Dan Bernstein.
+
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::ImageSource::setData):
+ Remove this code. Firstly, it's in a USE(CG) && !PLATFORM(COCOA) && !PLATFORM(WIN)
+ block, and that's simply not a thing. Secondly, the referenced bug was fixed in Lion.
+
2014-09-08 Gyuyoung Kim <[email protected]>
Introduce CSS_RULE_TYPE_CASTS, and use it
Modified: trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp (173388 => 173389)
--- trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp 2014-09-08 18:14:24 UTC (rev 173388)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp 2014-09-08 18:32:12 UTC (rev 173389)
@@ -150,16 +150,8 @@
// to wrap itself inside CFData to get around this, ensuring that ImageIO is really looking at the SharedBuffer.
CGImageSourceUpdateData(m_decoder, data->createCFData().get(), allDataReceived);
#else
- if (!m_decoder) {
+ if (!m_decoder)
m_decoder = CGImageSourceCreateIncremental(0);
- } else if (allDataReceived) {
-#if !PLATFORM(WIN)
- // 10.6 bug workaround: image sources with final=false fail to draw into PDF contexts, so re-create image source
- // when data is complete. <rdar://problem/7874035> (<http://openradar.appspot.com/7874035>)
- CFRelease(m_decoder);
- m_decoder = CGImageSourceCreateIncremental(0);
-#endif
- }
// Create a CGDataProvider to wrap the SharedBuffer.
data->ref();
// We use the GetBytesAtPosition callback rather than the GetBytePointer one because SharedBuffer
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
