Title: [173432] trunk/Source/WebInspectorUI
Revision
173432
Author
[email protected]
Date
2014-09-09 10:31:18 -0700 (Tue, 09 Sep 2014)

Log Message

Web Inspector: Fix ESLint no-extra-semi
https://bugs.webkit.org/show_bug.cgi?id=136666

Reviewed by Andy Estes.

Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
semicolons as identified by ESLint.

* .eslintrc:
* Tools/PrettyPrinting/Formatter.js:
(Formatter):
* UserInterface/Controllers/Formatter.js:
(Formatter):
* UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.getImageSize.imageDidLoad):
(WebInspector.Resource.prototype.getImageSize):
* UserInterface/Views/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
* UserInterface/Views/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/.eslintrc (173431 => 173432)


--- trunk/Source/WebInspectorUI/.eslintrc	2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/.eslintrc	2014-09-09 17:31:18 UTC (rev 173432)
@@ -58,6 +58,7 @@
     "rules": {
         "eqeqeq": 2,
         "curly": 0,
+        "no-extra-semi": 2,
         "quotes": [2, "double"],
         "no-underscore-dangle": 0,
         "new-parens": 0,

Modified: trunk/Source/WebInspectorUI/ChangeLog (173431 => 173432)


--- trunk/Source/WebInspectorUI/ChangeLog	2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-09-09 17:31:18 UTC (rev 173432)
@@ -1,5 +1,30 @@
 2014-09-09  Jono Wells  <[email protected]>
 
+        Web Inspector: Fix ESLint no-extra-semi
+        https://bugs.webkit.org/show_bug.cgi?id=136666
+
+        Reviewed by Andy Estes.
+
+        Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
+        semicolons as identified by ESLint.
+
+        * .eslintrc:
+        * Tools/PrettyPrinting/Formatter.js:
+        (Formatter):
+        * UserInterface/Controllers/Formatter.js:
+        (Formatter):
+        * UserInterface/Models/Resource.js:
+        (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
+        (WebInspector.Resource.prototype.getImageSize):
+        * UserInterface/Views/LayerTreeSidebarPanel.js:
+        (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
+        (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
+        * UserInterface/Views/ObjectPropertiesSection.js:
+        (WebInspector.ObjectPropertyTreeElement.prototype.callback):
+        (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
+
+2014-09-09  Jono Wells  <[email protected]>
+
         Web Inspector: Fix ESLint semi (missing semicolon)
         https://bugs.webkit.org/show_bug.cgi?id=136665
 

Modified: trunk/Source/WebInspectorUI/Tools/PrettyPrinting/Formatter.js (173431 => 173432)


--- trunk/Source/WebInspectorUI/Tools/PrettyPrinting/Formatter.js	2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/Tools/PrettyPrinting/Formatter.js	2014-09-09 17:31:18 UTC (rev 173432)
@@ -33,7 +33,7 @@
 
     this._lastToken = null;
     this._lastContent = "";
-};
+}
 
 Formatter.prototype = {
     constructor: Formatter,

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/Formatter.js (173431 => 173432)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/Formatter.js	2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/Formatter.js	2014-09-09 17:31:18 UTC (rev 173432)
@@ -33,7 +33,7 @@
 
     this._lastToken = null;
     this._lastContent = "";
-};
+}
 
 Formatter.prototype = {
     constructor: Formatter,

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js (173431 => 173432)


--- trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js	2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js	2014-09-09 17:31:18 UTC (rev 173432)
@@ -668,7 +668,7 @@
             };
             
             callback(this._imageSize);
-        };
+        }
 
         // Create an <img> element that we'll use to load the image resource
         // so that we can query its intrinsic size.

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js (173431 => 173432)


--- trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js	2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js	2014-09-09 17:31:18 UTC (rev 173432)
@@ -181,7 +181,7 @@
             var item1 = a.layer[sortColumnIdentifier] || 0;
             var item2 = b.layer[sortColumnIdentifier] || 0;
             return item1 - item2;
-        };
+        }
 
         this._dataGrid.sortNodes(comparator);
         this._updatePopoverForSelectedNode();

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPropertiesSection.js (173431 => 173432)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPropertiesSection.js	2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPropertiesSection.js	2014-09-09 17:31:18 UTC (rev 173432)
@@ -335,7 +335,7 @@
                 // Call updateSiblings since their value might be based on the value that just changed.
                 this.updateSiblings();
             }
-        };
+        }
         this.property.parentObject.setPropertyValue(this.property.name, _expression_.trim(), callback.bind(this));
     }
 };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to