[webkit-changes] [173443] trunk/Source

Tue, 09 Sep 2014 14:49:46 -0700

Title: [173443] trunk/Source
Revision
173443
Author
[email protected]
Date
2014-09-09 14:49:21 -0700 (Tue, 09 Sep 2014)

Log Message

Disable the "unreachable-code" warning
https://bugs.webkit.org/show_bug.cgi?id=136677

Patch by Benjamin Poulain <[email protected]> on 2014-09-09
Reviewed by Darin Adler.

Source/_javascript_Core:

* Configurations/Base.xcconfig:

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig:

Source/WebInspectorUI:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

Source/WTF:

The warning causes various build errors depending on which Clang you are using.

For example, with recent clangs, it breaks all the ARCHS dependent code like this:
    if (sizeof(uintptr_t) == 4)
        // Something for 32 bits.
    else
        // Somethign for 64 bits.

* Configurations/Base.xcconfig:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (173442 => 173443)


--- trunk/Source/_javascript_Core/ChangeLog	2014-09-09 21:43:57 UTC (rev 173442)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-09-09 21:49:21 UTC (rev 173443)
@@ -1,3 +1,12 @@
+2014-09-09  Benjamin Poulain  <[email protected]>
+
+        Disable the "unreachable-code" warning
+        https://bugs.webkit.org/show_bug.cgi?id=136677
+
+        Reviewed by Darin Adler.
+
+        * Configurations/Base.xcconfig:
+
 2014-09-08  Filip Pizlo  <[email protected]>
 
         DFG should have a reusable SSA builder

Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (173442 => 173443)


--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig	2014-09-09 21:43:57 UTC (rev 173442)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig	2014-09-09 21:49:21 UTC (rev 173443)
@@ -32,7 +32,6 @@
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
-CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 COMBINE_HIDPI_IMAGES = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;

Modified: trunk/Source/ThirdParty/ChangeLog (173442 => 173443)


--- trunk/Source/ThirdParty/ChangeLog	2014-09-09 21:43:57 UTC (rev 173442)
+++ trunk/Source/ThirdParty/ChangeLog	2014-09-09 21:49:21 UTC (rev 173443)
@@ -1,3 +1,12 @@
+2014-09-09  Benjamin Poulain  <[email protected]>
+
+        Disable the "unreachable-code" warning
+        https://bugs.webkit.org/show_bug.cgi?id=136677
+
+        Reviewed by Darin Adler.
+
+        * gtest/xcode/Config/General.xcconfig:
+
 2014-09-06  Darin Adler  <[email protected]>
 
         Make updates suggested by new version of Xcode

Modified: trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig (173442 => 173443)


--- trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig	2014-09-09 21:43:57 UTC (rev 173442)
+++ trunk/Source/ThirdParty/gtest/xcode/Config/General.xcconfig	2014-09-09 21:49:21 UTC (rev 173443)
@@ -28,7 +28,6 @@
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
-CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 ENABLE_STRICT_OBJC_MSGSEND = YES;
 GCC_WARN_64_TO_32_BIT_CONVERSION = YES;

Modified: trunk/Source/WTF/ChangeLog (173442 => 173443)


--- trunk/Source/WTF/ChangeLog	2014-09-09 21:43:57 UTC (rev 173442)
+++ trunk/Source/WTF/ChangeLog	2014-09-09 21:49:21 UTC (rev 173443)
@@ -1,3 +1,20 @@
+2014-09-09  Benjamin Poulain  <[email protected]>
+
+        Disable the "unreachable-code" warning
+        https://bugs.webkit.org/show_bug.cgi?id=136677
+
+        Reviewed by Darin Adler.
+
+        The warning causes various build errors depending on which Clang you are using.
+
+        For example, with recent clangs, it breaks all the ARCHS dependent code like this:
+            if (sizeof(uintptr_t) == 4)
+                // Something for 32 bits.
+            else
+                // Somethign for 64 bits.
+
+        * Configurations/Base.xcconfig:
+
 2014-09-07  Filip Pizlo  <[email protected]>
 
         DFG should have a reusable SSA builder

Modified: trunk/Source/WTF/Configurations/Base.xcconfig (173442 => 173443)


--- trunk/Source/WTF/Configurations/Base.xcconfig	2014-09-09 21:43:57 UTC (rev 173442)
+++ trunk/Source/WTF/Configurations/Base.xcconfig	2014-09-09 21:49:21 UTC (rev 173443)
@@ -32,7 +32,6 @@
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
-CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 COMBINE_HIDPI_IMAGES = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;

Modified: trunk/Source/WebInspectorUI/ChangeLog (173442 => 173443)


--- trunk/Source/WebInspectorUI/ChangeLog	2014-09-09 21:43:57 UTC (rev 173442)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-09-09 21:49:21 UTC (rev 173443)
@@ -1,3 +1,12 @@
+2014-09-09  Benjamin Poulain  <[email protected]>
+
+        Disable the "unreachable-code" warning
+        https://bugs.webkit.org/show_bug.cgi?id=136677
+
+        Reviewed by Darin Adler.
+
+        * Configurations/Base.xcconfig:
+
 2014-09-08  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: Fix ESLint no-trailing-spaces warnings

Modified: trunk/Source/WebInspectorUI/Configurations/Base.xcconfig (173442 => 173443)


--- trunk/Source/WebInspectorUI/Configurations/Base.xcconfig	2014-09-09 21:43:57 UTC (rev 173442)
+++ trunk/Source/WebInspectorUI/Configurations/Base.xcconfig	2014-09-09 21:49:21 UTC (rev 173443)
@@ -14,7 +14,6 @@
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
-CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 ENABLE_STRICT_OBJC_MSGSEND = YES;
 GCC_C_LANGUAGE_STANDARD = gnu99;

Modified: trunk/Source/WebKit/mac/ChangeLog (173442 => 173443)


--- trunk/Source/WebKit/mac/ChangeLog	2014-09-09 21:43:57 UTC (rev 173442)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-09-09 21:49:21 UTC (rev 173443)
@@ -1,3 +1,12 @@
+2014-09-09  Benjamin Poulain  <[email protected]>
+
+        Disable the "unreachable-code" warning
+        https://bugs.webkit.org/show_bug.cgi?id=136677
+
+        Reviewed by Darin Adler.
+
+        * Configurations/Base.xcconfig:
+
 2014-09-08  Maciej Stachowiak  <[email protected]>
 
         Fix 32-bit Mac build for new warnings

Modified: trunk/Source/WebKit/mac/Configurations/Base.xcconfig (173442 => 173443)


--- trunk/Source/WebKit/mac/Configurations/Base.xcconfig	2014-09-09 21:43:57 UTC (rev 173442)
+++ trunk/Source/WebKit/mac/Configurations/Base.xcconfig	2014-09-09 21:49:21 UTC (rev 173443)
@@ -32,7 +32,6 @@
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
-CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 COMBINE_HIDPI_IMAGES = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;

Modified: trunk/Source/WebKit2/ChangeLog (173442 => 173443)


--- trunk/Source/WebKit2/ChangeLog	2014-09-09 21:43:57 UTC (rev 173442)
+++ trunk/Source/WebKit2/ChangeLog	2014-09-09 21:49:21 UTC (rev 173443)
@@ -1,3 +1,12 @@
+2014-09-09  Benjamin Poulain  <[email protected]>
+
+        Disable the "unreachable-code" warning
+        https://bugs.webkit.org/show_bug.cgi?id=136677
+
+        Reviewed by Darin Adler.
+
+        * Configurations/Base.xcconfig:
+
 2014-09-09  Dan Bernstein  <[email protected]>
 
         [Cocoa] -[WKBackForwardList backList] contains an unnecessary nil check

Modified: trunk/Source/WebKit2/Configurations/Base.xcconfig (173442 => 173443)


--- trunk/Source/WebKit2/Configurations/Base.xcconfig	2014-09-09 21:43:57 UTC (rev 173442)
+++ trunk/Source/WebKit2/Configurations/Base.xcconfig	2014-09-09 21:49:21 UTC (rev 173443)
@@ -32,7 +32,6 @@
 CLANG_WARN_EMPTY_BODY = YES;
 CLANG_WARN_ENUM_CONVERSION = YES;
 CLANG_WARN_INT_CONVERSION = YES;
-CLANG_WARN_UNREACHABLE_CODE = YES;
 CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 COMBINE_HIDPI_IMAGES = NO;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to