Title: [173462] trunk/Source/WebInspectorUI
- Revision
- 173462
- Author
- [email protected]
- Date
- 2014-09-10 08:49:02 -0700 (Wed, 10 Sep 2014)
Log Message
Web Inspector: Fix ESLint* no-avoidable-bind warnings
https://bugs.webkit.org/show_bug.cgi?id=136690
Patch by Joseph Pecoraro <[email protected]> on 2014-09-10
Reviewed by Timothy Hatcher.
* UserInterface/Protocol/RemoteObject.js:
(WebInspector.LocalJSONObject.prototype._children):
* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel):
* UserInterface/Views/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._updateDataGrid):
* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._filterMessages):
* UserInterface/Views/TextResourceContentView.js:
(WebInspector.TextResourceContentView.prototype.get supplementalRepresentedObjects):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (173461 => 173462)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-09-10 14:59:32 UTC (rev 173461)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-09-10 15:49:02 UTC (rev 173462)
@@ -1,3 +1,21 @@
+2014-09-10 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Fix ESLint* no-avoidable-bind warnings
+ https://bugs.webkit.org/show_bug.cgi?id=136690
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Protocol/RemoteObject.js:
+ (WebInspector.LocalJSONObject.prototype._children):
+ * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+ (WebInspector.CSSStyleDetailsSidebarPanel):
+ * UserInterface/Views/LayerTreeSidebarPanel.js:
+ (WebInspector.LayerTreeSidebarPanel.prototype._updateDataGrid):
+ * UserInterface/Views/LogContentView.js:
+ (WebInspector.LogContentView.prototype._filterMessages):
+ * UserInterface/Views/TextResourceContentView.js:
+ (WebInspector.TextResourceContentView.prototype.get supplementalRepresentedObjects):
+
2014-09-09 Benjamin Poulain <[email protected]>
Disable the "unreachable-code" warning
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js (173461 => 173462)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js 2014-09-10 14:59:32 UTC (rev 173461)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js 2014-09-10 15:49:02 UTC (rev 173462)
@@ -355,7 +355,7 @@
return new WebInspector.RemoteObjectProperty(propName, new WebInspector.LocalJSONObject(this._value[propName]));
}
if (!this._cachedChildren)
- this._cachedChildren = Object.keys(this._value || {}).map(buildProperty.bind(this));
+ this._cachedChildren = Object.keys(this._value || {}).map(buildProperty, this);
return this._cachedChildren;
},
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js (173461 => 173462)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2014-09-10 14:59:32 UTC (rev 173461)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2014-09-10 15:49:02 UTC (rev 173462)
@@ -66,7 +66,7 @@
}
groupElement.appendChild(labelElement);
- }.bind(this));
+ }, this);
this._contentElement.appendChild(this._forcedPseudoClassContainer);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js (173461 => 173462)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js 2014-09-10 14:59:32 UTC (rev 173461)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js 2014-09-10 15:49:02 UTC (rev 173462)
@@ -272,19 +272,19 @@
dataGrid.removeChild(node);
delete this._dataGridNodesByLayerId[layer.layerId];
}
- }.bind(this));
+ }, this);
mutations.additions.forEach(function(layer) {
var node = this._dataGridNodeForLayer(layer);
if (node)
dataGrid.appendChild(node);
- }.bind(this));
+ }, this);
mutations.preserved.forEach(function(layer) {
var node = this._dataGridNodesByLayerId[layer.layerId];
if (node)
node.layer = layer;
- }.bind(this));
+ }, this);
this._sortDataGrid();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (173461 => 173462)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2014-09-10 14:59:32 UTC (rev 173461)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2014-09-10 15:49:02 UTC (rev 173462)
@@ -667,7 +667,7 @@
classList.remove(WebInspector.LogContentView.SelectedStyleClassName);
classList.add(WebInspector.LogContentView.FilteredOutStyleClassName);
}
- }.bind(this));
+ }, this);
this._performSearch();
},
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js (173461 => 173462)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js 2014-09-10 14:59:32 UTC (rev 173461)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js 2014-09-10 15:49:02 UTC (rev 173462)
@@ -89,7 +89,7 @@
{
var objects = WebInspector.probeManager.probeSets.filter(function(probeSet) {
return this._resource.url ="" probeSet.breakpoint.url;
- }.bind(this));
+ }, this);
// If the SourceCodeTextEditor has an executionLineNumber, we can assume
// it is always the active call frame.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
