Title: [173466] trunk/Source/WebInspectorUI
- Revision
- 173466
- Author
- [email protected]
- Date
- 2014-09-10 09:00:24 -0700 (Wed, 10 Sep 2014)
Log Message
Web Inspector: Fix ESLint no-undef warnings
https://bugs.webkit.org/show_bug.cgi?id=136660
Patch by Joseph Pecoraro <[email protected]> on 2014-09-10
Reviewed by Timothy Hatcher.
* UserInterface/Models/DOMSearchMatchObject.js:
(WebInspector.DOMSearchMatchObject.prototype._generateClassName):
(WebInspector.DOMSearchMatchObject.titleForDOMNode):
* UserInterface/Models/Gradient.js:
(WebInspector.Gradient.fromString):
* UserInterface/Views/CodeMirrorAdditions.js:
* UserInterface/Views/ReplayDashboardView.js:
(WebInspector.ReplayDashboardView):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (173465 => 173466)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-09-10 15:58:03 UTC (rev 173465)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-09-10 16:00:24 UTC (rev 173466)
@@ -1,5 +1,21 @@
2014-09-10 Joseph Pecoraro <[email protected]>
+ Web Inspector: Fix ESLint no-undef warnings
+ https://bugs.webkit.org/show_bug.cgi?id=136660
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Models/DOMSearchMatchObject.js:
+ (WebInspector.DOMSearchMatchObject.prototype._generateClassName):
+ (WebInspector.DOMSearchMatchObject.titleForDOMNode):
+ * UserInterface/Models/Gradient.js:
+ (WebInspector.Gradient.fromString):
+ * UserInterface/Views/CodeMirrorAdditions.js:
+ * UserInterface/Views/ReplayDashboardView.js:
+ (WebInspector.ReplayDashboardView):
+
+2014-09-10 Joseph Pecoraro <[email protected]>
+
Web Inspector: Remove unused Console search highlight methods
https://bugs.webkit.org/show_bug.cgi?id=136661
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DOMSearchMatchObject.js (173465 => 173466)
--- trunk/Source/WebInspectorUI/UserInterface/Models/DOMSearchMatchObject.js 2014-09-10 15:58:03 UTC (rev 173465)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DOMSearchMatchObject.js 2014-09-10 16:00:24 UTC (rev 173466)
@@ -98,7 +98,7 @@
return WebInspector.DOMSearchMatchObject.DOMMatchCharacterDataIconStyleClassName;
default:
- console.error("Unknown DOM node type: ", node.nodeType());
+ console.error("Unknown DOM node type: ", this._domNode.nodeType());
return WebInspector.DOMSearchMatchObject.DOMMatchNodeIconStyleClassName;
}
}
@@ -128,7 +128,7 @@
var title = "<!DOCTYPE " + domNode.nodeName();
if (domNode.publicId) {
title += " PUBLIC \"" + domNode.publicId + "\"";
- if (node.systemId)
+ if (domNode.systemId)
title += " \"" + domNode.systemId + "\"";
} else if (domNode.systemId)
title += " SYSTEM \"" + domNode.systemId + "\"";
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Gradient.js (173465 => 173466)
--- trunk/Source/WebInspectorUI/UserInterface/Models/Gradient.js 2014-09-10 15:58:03 UTC (rev 173465)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Gradient.js 2014-09-10 16:00:24 UTC (rev 173466)
@@ -48,6 +48,7 @@
var currentParam = "";
var openParentheses = 0;
var ch = openingParenthesisIndex + 1;
+ var c = null;
while (c = cssString[ch]) {
if (c === "(")
openParentheses++;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js (173465 => 173466)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js 2014-09-10 15:58:03 UTC (rev 173465)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js 2014-09-10 16:00:24 UTC (rev 173466)
@@ -552,6 +552,7 @@
var endChar = match.index + match[0].length;
var openParentheses = 0;
+ var c = null;
while (c = lineContent[endChar]) {
if (c === "(")
openParentheses++;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ReplayDashboardView.js (173465 => 173466)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ReplayDashboardView.js 2014-09-10 15:58:03 UTC (rev 173465)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ReplayDashboardView.js 2014-09-10 16:00:24 UTC (rev 173466)
@@ -30,8 +30,6 @@
this._navigationBar = new WebInspector.NavigationBar;
this.element.appendChild(this._navigationBar.element);
- replayManager = WebInspector.replayManager;
-
this._captureButtonItem = new WebInspector.ActivateButtonNavigationItem("replay-dashboard-capture", WebInspector.UIString("Start Recording"), WebInspector.UIString("Stop Recording"), "Images/ReplayRecordingButton.svg", 16, 16);
this._captureButtonItem.addEventListener(WebInspector.ButtonNavigationItem.Event.Clicked, this._captureButtonItemClicked, this);
this._captureButtonItem.hidden = true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
